Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2149233004: Fix flaky toBlob tests (Closed)

Created:
4 years, 5 months ago by xlai (Olivia)
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky toBlob tests Some layout tests are flaky on WebKit Leak bot due to m_document introduced to CanvasAsyncBlobCreator in https://codereview.chromium.org/2143353002. TBR=haraken@chromium.org BUG=628308 Committed: https://crrev.com/20989491201825820c93697de6d92d3b148b10b5 Cr-Commit-Position: refs/heads/master@{#405622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
xlai (Olivia)
Fixing leak on WebKit Linux Leak bot due to https://codereview.chromium.org/2143353002.
4 years, 5 months ago (2016-07-14 22:04:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149233004/1
4 years, 5 months ago (2016-07-14 22:07:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 23:23:18 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 23:23:23 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/20989491201825820c93697de6d92d3b148b10b5 Cr-Commit-Position: refs/heads/master@{#405622}
4 years, 5 months ago (2016-07-14 23:24:57 UTC) #10
haraken
4 years, 5 months ago (2016-07-15 00:06:06 UTC) #11
Message was sent while issue was closed.
Thanks for the fix, LGTM!

Powered by Google App Engine
This is Rietveld 408576698