Reland of "Fix build of Widevine CDM stub on Mac"

Reland of "Fix build of Widevine CDM stub on Mac"

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

This CL relands https://codereview.chromium.org/2117343005/ with the
following change:

The new 'widevinecdm_binary' target is now defined conditionally for the
case when it is really needed, to fix the ninja error "multiple rules
generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll".

BUG=622282
TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium -Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm' is successful

Committed: https://crrev.com/117144d7ad598ec731f258f5272142708274d635
Cr-Commit-Position: refs/heads/master@{#405635}

[wdzierzanowski, 2016-07-14 21:23:40]

wdzierzanowski@opera.com changed reviewers:
+ ddorwin@chromium.org

[wdzierzanowski, 2016-07-14 21:23:40]

ddorwin: Now with the reland fix in a separate patch set :) PTAL

[ddorwin, 2016-07-14 22:26:31]

Thank you. LGTM with nit. Go ahead and CQ after fixing the nit.

https://codereview.chromium.org/2149233003/diff/20001/third_party/widevine/cd...
File third_party/widevine/cdm/widevine_cdm.gyp (right):

https://codereview.chromium.org/2149233003/diff/20001/third_party/widevine/cd...
third_party/widevine/cdm/widevine_cdm.gyp:202: # See "widevinecdm_binary" above.
nit: It is now below. You could just remove "above".

[wdzierzanowski, 2016-07-14 23:14:50]

https://codereview.chromium.org/2149233003/diff/20001/third_party/widevine/cd...
File third_party/widevine/cdm/widevine_cdm.gyp (right):

https://codereview.chromium.org/2149233003/diff/20001/third_party/widevine/cd...
third_party/widevine/cdm/widevine_cdm.gyp:202: # See "widevinecdm_binary" above.
On 2016/07/14 22:26:31, ddorwin wrote:
> nit: It is now below. You could just remove "above".

Done.

[wdzierzanowski, 2016-07-14 23:15:25]

The CQ bit was checked by wdzierzanowski@opera.com

[wdzierzanowski, 2016-07-14 23:15:25]

The patchset sent to the CQ was uploaded after l-g-t-m from ddorwin@chromium.org
Link to the patchset: https://codereview.chromium.org/2149233003/#ps40001
(title: "Remove outdated "above"")

[commit-bot: I haz the power, 2016-07-14 23:16:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:50:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 23:53:26]

Description was changed from

==========
Reland of "Fix build of Widevine CDM stub on Mac"

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

This CL relands https://codereview.chromium.org/2117343005/ with the
following change:

The new 'widevinecdm_binary' target is now defined conditionally for the
case when it is really needed, to fix the ninja error "multiple rules
generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll".

BUG=622282

TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium
-Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm'
is successful
==========

to

==========
Reland of "Fix build of Widevine CDM stub on Mac"

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

This CL relands https://codereview.chromium.org/2117343005/ with the
following change:

The new 'widevinecdm_binary' target is now defined conditionally for the
case when it is really needed, to fix the ninja error "multiple rules
generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll".

BUG=622282

TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium
-Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm'
is successful

Committed: https://crrev.com/117144d7ad598ec731f258f5272142708274d635
Cr-Commit-Position: refs/heads/master@{#405635}
==========

[commit-bot: I haz the power, 2016-07-14 23:53:27]

Patchset 3 (id:??) landed as
https://crrev.com/117144d7ad598ec731f258f5272142708274d635
Cr-Commit-Position: refs/heads/master@{#405635}