Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2149213002: Document GN invoker and target name variables. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document GN invoker and target name variables. There was some confusion about this, and one would also expect that these build-in variables would be listed in the help under the other built-in variables. BUG=468991 Committed: https://crrev.com/d93e5cf487e27ae69e20ea4fabb35c9246864302 Cr-Commit-Position: refs/heads/master@{#405584}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -9 lines) Patch
M tools/gn/docs/reference.md View 1 2 5 chunks +120 lines, -2 lines 0 comments Download
M tools/gn/functions.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/template.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M tools/gn/variables.h View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 4 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
brettw
.
4 years, 5 months ago (2016-07-14 21:00:17 UTC) #1
brettw
4 years, 5 months ago (2016-07-14 21:01:08 UTC) #3
Dirk Pranke
lgtm as long as you update reference.md as well.
4 years, 5 months ago (2016-07-14 21:08:33 UTC) #6
brettw
reference
4 years, 5 months ago (2016-07-14 21:13:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149213002/40001
4 years, 5 months ago (2016-07-14 21:14:31 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 21:51:33 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 21:51:47 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:53:37 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d93e5cf487e27ae69e20ea4fabb35c9246864302
Cr-Commit-Position: refs/heads/master@{#405584}

Powered by Google App Engine
This is Rietveld 408576698