Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2149173002:
🎩 Fix NPE in TabPersistentStore when no state file exists (Closed)
DescriptionFix NPE in TabPersistentStore when no state file exists
It was being silently ignored thanks to the catch-all try block, but we
should fix it.
BUG=none
Committed: https://crrev.com/d48d9aabdf86f9dd80dbe445cd7dc8729bc893fc
Cr-Commit-Position: refs/heads/master@{#406057}
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
agrieve@chromium.org changed reviewers: + dfalcantara@chromium.org, wnwen@chromium.org
This isn't really fixing anything, is it? It just silently checks for a null pointer and drops through without saying that it happened. It at least used to throw a log before. Could you send out a Log.d when this actually happens?
Description was changed from ========== Fix NPE in TabPersistentStore when mPrefetchTabListTask is canceled It was being silently ignored thanks to the catch-all try block, but we should fix it. BUG=none ========== to ========== Fix NPE in TabPersistentStore when no state file exists It was being silently ignored thanks to the catch-all try block, but we should fix it. BUG=none ==========
On 2016/07/15 00:00:05, dfalcantara wrote: > This isn't really fixing anything, is it? It just silently checks for a null > pointer and drops through without saying that it happened. It at least used to > throw a log before. Could you send out a Log.d when this actually happens? Corrected the description. I just happens when the state file doesn't exist (not when cancelled). Here's the stack: 07-15 09:27:50.787 14743 14743 D cr_tabmodel: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.io.DataInputStream.readInt()' on a null obj ect reference 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at org.chromium.chrome.browser.tabmodel.TabPersistentStore.readSavedStateFile(TabPersistentStore.java:865) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at org.chromium.chrome.browser.tabmodel.TabPersistentStore.loadState(TabPersistentStore.java:388) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.loadState(TabModelSelectorImpl.java:279) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at org.chromium.chrome.browser.ChromeTabbedActivity.initializeState(ChromeTabbedActivity.java:567) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at org.chromium.chrome.browser.init.ChromeBrowserInitializer$6.initFunction(ChromeBrowserInitializer.java:295) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at org.chromium.chrome.browser.init.ChromeBrowserInitializer$1NativeInitTask.run(ChromeBrowserInitializer.java:240) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at android.os.Handler.handleCallback(Handler.java:751) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at android.os.Handler.dispatchMessage(Handler.java:95) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at android.os.Looper.loop(Looper.java:154) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at android.app.ActivityThread.main(ActivityThread.java:6077) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at java.lang.reflect.Method.invoke(Native Method) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865) 07-15 09:27:50.787 14743 14743 D cr_tabmodel: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)
Er, that's fine then. lgtm
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix NPE in TabPersistentStore when no state file exists It was being silently ignored thanks to the catch-all try block, but we should fix it. BUG=none ========== to ========== Fix NPE in TabPersistentStore when no state file exists It was being silently ignored thanks to the catch-all try block, but we should fix it. BUG=none ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Fix NPE in TabPersistentStore when no state file exists It was being silently ignored thanks to the catch-all try block, but we should fix it. BUG=none ========== to ========== Fix NPE in TabPersistentStore when no state file exists It was being silently ignored thanks to the catch-all try block, but we should fix it. BUG=none Committed: https://crrev.com/d48d9aabdf86f9dd80dbe445cd7dc8729bc893fc Cr-Commit-Position: refs/heads/master@{#406057} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d48d9aabdf86f9dd80dbe445cd7dc8729bc893fc Cr-Commit-Position: refs/heads/master@{#406057} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
