Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: chrome/browser/resources/pdf/navigator.js

Issue 2149153003: Links in PDF should be opened in new background tabs when ctrl + left clicked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Links in PDF should be opened in new background tabs when ctrl + left clicked. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/pdf/navigator.js
diff --git a/chrome/browser/resources/pdf/navigator.js b/chrome/browser/resources/pdf/navigator.js
index 9a2f6aaedfcdef8c0a428480ddb00f00191cc4e3..93445413df9c719c54a42ca9b065facee1c13b78 100644
--- a/chrome/browser/resources/pdf/navigator.js
+++ b/chrome/browser/resources/pdf/navigator.js
@@ -11,19 +11,19 @@
* @param {Object} paramsParser The object for URL parsing.
* @param {Function} navigateInCurrentTabCallback The Callback function that
* gets called when navigation happens in the current tab.
- * @param {Function} navigateInNewTabCallback The Callback function that gets
- * called when navigation happens in the new tab.
+ * @param {Function} navigateInNewBackgroundTabCallback The Callback function
+ * that gets called when navigation happens in the new background tab.
*/
function Navigator(originalUrl,
viewport,
paramsParser,
navigateInCurrentTabCallback,
- navigateInNewTabCallback) {
+ navigateInNewBackgroundTabCallback) {
this.originalUrl_ = originalUrl;
this.viewport_ = viewport;
this.paramsParser_ = paramsParser;
this.navigateInCurrentTabCallback_ = navigateInCurrentTabCallback;
- this.navigateInNewTabCallback_ = navigateInNewTabCallback;
+ this.navigateInNewBackgroundTabCallback_ = navigateInNewBackgroundTabCallback;
}
Navigator.prototype = {
@@ -59,7 +59,7 @@ Navigator.prototype = {
return;
if (newTab) {
- this.navigateInNewTabCallback_(url);
+ this.navigateInNewBackgroundTabCallback_(url);
} else {
this.paramsParser_.getViewportFromUrlParams(
url, this.onViewportReceived_.bind(this));

Powered by Google App Engine
This is Rietveld 408576698