Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2296)

Unified Diff: chrome/browser/pdf/pdf_extension_test.cc

Issue 2149153003: Links in PDF should be opened in new background tabs when ctrl + left clicked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/navigator.js » ('j') | chrome/browser/resources/pdf/pdf.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/pdf/pdf_extension_test.cc
diff --git a/chrome/browser/pdf/pdf_extension_test.cc b/chrome/browser/pdf/pdf_extension_test.cc
index 03e31b51bde9ee73a924cd5b5c8d0e1ad9a9c00f..f1d05b98cd82d226d9b50985d96938f1ad5d66eb 100644
--- a/chrome/browser/pdf/pdf_extension_test.cc
+++ b/chrome/browser/pdf/pdf_extension_test.cc
@@ -632,10 +632,14 @@ IN_PROC_BROWSER_TEST_F(PDFExtensionTest, LinkMiddleClick) {
int tab_count = browser()->tab_strip_model()->count();
ASSERT_EQ(2, tab_count);
- // TODO(jaepark): Middle mouse clicking on a link should not change
- // the focus of the tab. See http://crbug.com/628054.
- content::WebContents* new_web_contents =
+ content::WebContents* active_web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
+ ASSERT_EQ(web_contents, active_web_contents);
+
+
+ content::WebContents* new_web_contents =
+ browser()->tab_strip_model()->GetWebContentsAt(1);
+ ASSERT_TRUE(new_web_contents);
ASSERT_NE(web_contents, new_web_contents);
const GURL& url = new_web_contents->GetURL();
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/navigator.js » ('j') | chrome/browser/resources/pdf/pdf.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698