Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2149143002: Move PageOverlay::Delegate off the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mild cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/PageOverlay.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 28293f2f11b500f9ee6c578de4bc874b83643fe7..d85d3487432894a7f1cdc13d8caf50f187d64d1f 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -105,12 +105,6 @@ public:
: m_overlay(&overlay)
{ }
- DEFINE_INLINE_VIRTUAL_TRACE()
- {
- visitor->trace(m_overlay);
- PageOverlay::Delegate::trace(visitor);
- }
-
void paintPageOverlay(const PageOverlay&, GraphicsContext& graphicsContext, const WebSize& webViewSize) const override
{
if (m_overlay->isEmpty())
@@ -122,7 +116,7 @@ public:
}
private:
- Member<InspectorOverlay> m_overlay;
+ Persistent<InspectorOverlay> m_overlay;
};
@@ -220,7 +214,7 @@ void InspectorOverlay::init(InspectorCSSAgent* cssAgent, V8InspectorSession* v8S
void InspectorOverlay::invalidate()
{
if (!m_pageOverlay)
- m_pageOverlay = PageOverlay::create(m_webViewImpl, new InspectorPageOverlayDelegate(*this));
+ m_pageOverlay = PageOverlay::create(m_webViewImpl, wrapUnique(new InspectorPageOverlayDelegate(*this)));
m_pageOverlay->update();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/PageOverlay.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698