Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2149093002: Reland "[interpreter] Reduce dependencies in bytecodes.{h,cc}" (Closed)

Created:
4 years, 5 months ago by oth
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[interpreter] Reduce dependencies in bytecodes.{h,cc}" > Original issue's description: > [interpreter] Reduce dependencies in bytecodes.{h,cc} > > This CL reduces the number of dependencies bytecodes.{h,cc} to facilitate > generating the bytecode peephole optimizer table during build. Specifically, > it avoids depending on v8_base. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/4edebb1cd870ae6c1359ad54f83e618e185883b1 > Cr-Commit-Position: refs/heads/master@{#37715} BUG=v8:4280 LOG=N Committed: https://crrev.com/0e20ae6d8d7cc91de7492b42106a448b8792f2de Cr-Commit-Position: refs/heads/master@{#37794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -527 lines) Patch
M BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M src/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/extensions/ignition-statistics-extension.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-array-writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
A src/interpreter/bytecode-decoder.h View 1 chunk +43 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-decoder.cc View 1 chunk +157 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-flags.h View 1 chunk +42 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-flags.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-pipeline.h View 1 chunk +2 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-register.h View 1 chunk +105 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-register.cc View 1 chunk +149 lines, -0 lines 0 comments Download
M src/interpreter/bytecodes.h View 7 chunks +9 lines, -145 lines 0 comments Download
M src/interpreter/bytecodes.cc View 5 chunks +7 lines, -305 lines 0 comments Download
M src/interpreter/handler-table-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/handler-table-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/runtime/runtime-interpreter.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 chunk +7 lines, -1 line 0 comments Download
A test/unittests/interpreter/bytecode-decoder-unittest.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecodes-unittest.cc View 2 chunks +1 line, -67 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
oth
Hey Ross and Michi, bad placement of static const value declaration lead to this CL ...
4 years, 5 months ago (2016-07-14 12:38:56 UTC) #4
Michael Starzinger
LGTM (rubber-stamp of "compiler").
4 years, 5 months ago (2016-07-14 12:40:00 UTC) #5
rmcilroy
LGTM, thanks.
4 years, 5 months ago (2016-07-15 09:37:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149093002/1
4 years, 5 months ago (2016-07-15 12:00:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 12:03:12 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 12:04:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e20ae6d8d7cc91de7492b42106a448b8792f2de
Cr-Commit-Position: refs/heads/master@{#37794}

Powered by Google App Engine
This is Rietveld 408576698