Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2149063002: Re-reland: Add MemoryCoordinator (Closed)

Created:
4 years, 5 months ago by bashi
Modified:
4 years, 5 months ago
Reviewers:
haraken, chrisha, jam, dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-reland: Add MemoryCoordinator This is second attempt. Hope GYP Mac is happy with this :( Original description: This CL adds MemoryCoordinator mojo interface and its implementation. When --enable-features=MemoryCoordinator is specified the browser and renderers create their MemoryCoordinators. MemoryCoordinatorImpl (which lives in the browser process) creates a mojo message pipe when a renderer is launched. This CL doesn't add actual handling of memory events, which will be implemented in follow-up CLs. BUG=617492 TBR=chrisha@chromium.org,haraken@chromium.org,dcheng@chromium.org,jam@chromium.org Committed: https://crrev.com/94d4a4349b199ffef3ee1c4a8616b05b225f7dc9 Cr-Commit-Position: refs/heads/master@{#405460}

Patch Set 1 #

Patch Set 2 : diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -33 lines) Patch
M components/memory_coordinator.gypi View 2 chunks +19 lines, -1 line 0 comments Download
M components/memory_coordinator/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/memory_coordinator/browser/BUILD.gn View 1 chunk +9 lines, -3 lines 0 comments Download
A components/memory_coordinator/browser/memory_coordinator.h View 1 chunk +42 lines, -0 lines 0 comments Download
A components/memory_coordinator/browser/memory_coordinator.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M components/memory_coordinator/child/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.h View 2 chunks +14 lines, -6 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.cc View 1 chunk +19 lines, -5 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl_unittest.cc View 5 chunks +15 lines, -17 lines 0 comments Download
M components/memory_coordinator/common/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A components/memory_coordinator/common/memory_coordinator_features.h View 1 chunk +24 lines, -0 lines 0 comments Download
A components/memory_coordinator/common/memory_coordinator_features.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M components/memory_coordinator/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/memory_coordinator/public/interfaces/memory_coordinator.mojom View 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +9 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +7 lines, -0 lines 0 comments Download
A content/browser/memory/memory_coordinator_browsertest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
bashi
This time I'm trying all *_gyp_* bots on mac. I'll land this if all bots ...
4 years, 5 months ago (2016-07-14 05:34:45 UTC) #1
haraken
LGTM
4 years, 5 months ago (2016-07-14 05:36:26 UTC) #2
bashi
On 2016/07/14 05:36:26, haraken wrote: > LGTM Bots are green. Trying to land (sorry for ...
4 years, 5 months ago (2016-07-14 07:14:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149063002/20001
4 years, 5 months ago (2016-07-14 07:15:11 UTC) #5
dcheng
lgtm
4 years, 5 months ago (2016-07-14 07:36:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/255750)
4 years, 5 months ago (2016-07-14 08:55:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149063002/20001
4 years, 5 months ago (2016-07-14 08:59:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 09:58:51 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 09:58:57 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/94d4a4349b199ffef3ee1c4a8616b05b225f7dc9 Cr-Commit-Position: refs/heads/master@{#405460}
4 years, 5 months ago (2016-07-14 10:00:44 UTC) #14
henrika (OOO until Aug 14)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2145403002/ by henrika@chromium.org. ...
4 years, 5 months ago (2016-07-14 11:19:18 UTC) #15
findit-for-me
4 years, 5 months ago (2016-07-14 11:19:53 UTC) #16
Message was sent while issue was closed.
FYI: Findit try jobs (rerunning failed compile or tests) identified this CL
at revision 405460 as the culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698