Update scroll layers' bounds_delta earlier during tree activation.

Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/fe9e63ecc3b6d320006ba0d22b7000eb0af30239
Cr-Commit-Position: refs/heads/master@{#406341}

[bokan, 2016-07-13 23:45:32]

Description was changed from

==========
Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
==========

to

==========
Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[bokan, 2016-07-13 23:47:23]

bokan@chromium.org changed reviewers:
+ ajuma@chromium.org

[bokan, 2016-07-13 23:47:23]

Hi Ali, ptal.

[bokan, 2016-07-13 23:47:30]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 23:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:11:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:11:35]

Dry run: This issue passed the CQ dry run.

[bokan, 2016-07-14 12:52:01]

Description was changed from

==========
Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[bokan, 2016-07-14 12:52:01]

bokan@chromium.org changed reviewers:
- ajuma@chromium.org

[bokan, 2016-07-14 12:52:53]

bokan@chromium.org changed reviewers:
+ weiliangc@chromium.org

[bokan, 2016-07-14 12:52:53]

Arg, everyone's OOO. Wei, could you take a look please? Thanks.

[bokan, 2016-07-18 14:44:54]

ping

[bokan, 2016-07-19 15:48:12]

bokan@chromium.org changed reviewers:
+ ajuma@chromium.org

[bokan, 2016-07-19 15:48:46]

Looks like Ali's back and Wei's out/busy. +ajuma@, ptal.

[ajuma, 2016-07-19 17:20:12]

lgtm

[bokan, 2016-07-19 17:32:16]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:34:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:34:26]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.blink
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-19 19:19:36]

Description was changed from

==========
Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-19 19:19:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-19 19:20:11]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 19:22:44]

Description was changed from

==========
Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Update scroll layers' bounds_delta earlier during tree activation.

When a tree activation occurs, we must update the property trees' bounds deltas
so that they get propagated across the trees. This was previously done in
LayerTreeHostImpl::ActivateSyncTree() and needs to happen before
updateViewportContainerSizes() is called, otherwise it will clamp scroll offsets
incorrectly becaues the bounds_deltas haven't been propagated yet.

However, this bug occurs because earlier in ActivateSyncTree(), in
LayerTreeImpl::PushPropertiesTo, we may change the top controls values when
PushTopControls is called and causes a change. This indirectly causes
UpdateViewportContainerSizes to be called which we must do after updating the
bounds deltas.

This CL moves the update to happen inside LayerTreeImpl::PushPropertiesTo near
the beginning. I've rewritten the ViewportBoundsDeltaOnTreeActivation test to
catch this. It was written to catch basically the same issue but with
UpdateViewportContainerSizes being called later than in this bug so checking for
this case should catch both.

BUG=627911
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/fe9e63ecc3b6d320006ba0d22b7000eb0af30239
Cr-Commit-Position: refs/heads/master@{#406341}
==========

[commit-bot: I haz the power, 2016-07-19 19:22:45]

Patchset 3 (id:??) landed as
https://crrev.com/fe9e63ecc3b6d320006ba0d22b7000eb0af30239
Cr-Commit-Position: refs/heads/master@{#406341}