Error out when merchant requests only unknown payment methods.

Error out when merchant requests only unknown payment methods.

If the merchant requests only payment methods that Chrome does not
support, then reject the show() promise with NotSupportedError.

BUG=628460
Committed: https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561
Cr-Commit-Position: refs/heads/master@{#406460}

[please use gerrit instead, 2016-07-15 01:46:27]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-07-15 01:46:51]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-07-15 01:46:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 01:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 01:49:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[please use gerrit instead, 2016-07-15 23:31:03]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-07-15 23:31:04]

dfalcantara@, ptal.

Please ignore the trybot failures. These are patch failures due to the another
patch not having landed yet.

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:226:

Move up this code unchanged to where the rest of validation happens.

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:230:
boolean arePaymentMethodsSupported = false;
Renamed isGettingInstruments into arePaymentMethodsSupported.

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:244:
if (!arePaymentMethodsSupported) {
This block is new.

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:783:

Moved up this function right under its last use in this file.

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:787:

Added ability to specify the reason for closing the dialog. "User cancel" is
default.

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:98:
triggerUIAndWait((CallbackHelper) helper);
This calls the more generic triggerUIAndWait() that does not capture the UI
reference.

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:99:
mUI = helper.getTarget();
This captures the UI reference.

https://codereview.chromium.org/2149023005/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:101:

PaymentsCallbackHelper is meant to capture a reference to the UI after it shows
up, but NotSupportedError is fired before UI. Therefore, we need a more generic
triggerUIAndWait() method that does not attempt to capture a reference to the
UI.

[gone, 2016-07-18 18:26:44]

lgtm

https://chromiumcodereview.appspot.com/2149023005/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://chromiumcodereview.appspot.com/2149023005/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:227:
mPendingApps = new ArrayList<>(mApps);
Add a comment here about what this codeblock is for.  Better yet, pull it out
into a private function so that this monolithic function doesn't grow any
further.

https://chromiumcodereview.appspot.com/2149023005/diff/40001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
(right):

https://chromiumcodereview.appspot.com/2149023005/diff/40001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java:118:
new Handler().postDelayed(new Runnable() {
I'm not sure what thread this Handler is created on; it's created using the
Looper for whatever triggers this code.  Does it matter whether that's the UI or
a background thread?

[please use gerrit instead, 2016-07-19 00:52:51]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 00:53:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 02:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:19:29]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[please use gerrit instead, 2016-07-19 22:10:32]

Will send to cq after linux_android_dbg_ng and linux_android_rel_ng try-bots
pass. (Not part of CQ, but they catch assertion failures.)

https://codereview.chromium.org/2149023005/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2149023005/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:227:
mPendingApps = new ArrayList<>(mApps);
On 2016/07/18 18:26:43, dfalcantara wrote:
> Add a comment here about what this codeblock is for.  Better yet, pull it out
> into a private function so that this monolithic function doesn't grow any
> further.

Done.

https://codereview.chromium.org/2149023005/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
(right):

https://codereview.chromium.org/2149023005/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java:118:
new Handler().postDelayed(new Runnable() {
On 2016/07/18 18:26:43, dfalcantara wrote:
> I'm not sure what thread this Handler is created on; it's created using the
> Looper for whatever triggers this code.  Does it matter whether that's the UI
or
> a background thread?

Should be UI thread. I've placed asserts next to onInstrumentsReady() to ensure
this.

[please use gerrit instead, 2016-07-19 23:35:12]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-07-19 23:35:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2149023005/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-19 23:36:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 00:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:29:21]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[please use gerrit instead, 2016-07-20 00:32:19]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2016-07-20 00:44:18]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-07-20 00:44:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2149023005/#ps120001
(title: "Fix findbugs")

[commit-bot: I haz the power, 2016-07-20 00:45:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 02:10:18]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-07-20 02:10:24]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 02:11:58]

Description was changed from

==========
Error out when merchant requests only unknown payment methods.

If the merchant requests only payment methods that Chrome does not
support, then reject the show() promise with NotSupportedError.

BUG=628460
==========

to

==========
Error out when merchant requests only unknown payment methods.

If the merchant requests only payment methods that Chrome does not
support, then reject the show() promise with NotSupportedError.

BUG=628460

Committed: https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561
Cr-Commit-Position: refs/heads/master@{#406460}
==========

[commit-bot: I haz the power, 2016-07-20 02:12:00]

Patchset 6 (id:??) landed as
https://crrev.com/3748272dc88b06912bf432655587dc7dd4a4a561
Cr-Commit-Position: refs/heads/master@{#406460}