Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2149003002: Update buildbot names to new ones (Closed)

Created:
4 years, 5 months ago by Wei Li
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Update buildbot names to new ones Buildbots are switched from GYP to GN builds (https://crrev.com/2142353004), so the bot names in commit queue need to be updated accordingly. BUG=pdfium:484 TBR=thestig@chromium.org NOTRY=true (trybots need this change to function) Committed: https://pdfium.googlesource.com/pdfium/+/2bc0f072e752521bee158729f5badea895ed0bb8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M infra/config/cq.cfg View 3 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149003002/1
4 years, 5 months ago (2016-07-14 07:19:52 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_xfa_rel_gn on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa_rel_gn/builds/767)
4 years, 5 months ago (2016-07-14 07:26:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149003002/1
4 years, 5 months ago (2016-07-14 07:27:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/2bc0f072e752521bee158729f5badea895ed0bb8
4 years, 5 months ago (2016-07-14 07:27:36 UTC) #10
Lei Zhang
4 years, 5 months ago (2016-07-14 09:45:03 UTC) #12
Message was sent while issue was closed.
lgtm

Forgot to add me as a reviewer, but no worries.

https://codereview.chromium.org/2149003002/diff/1/infra/config/cq.cfg
File infra/config/cq.cfg (right):

https://codereview.chromium.org/2149003002/diff/1/infra/config/cq.cfg#newcode43
infra/config/cq.cfg:43: name: "linux_xfa_rel_gyp"
Oh, because linux_xfa is GN now.

Powered by Google App Engine
This is Rietveld 408576698