media/gpu/vaapi_drm_picture.cc - Issue 2148983002: gpu: Take surface handle into account when importing buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/vaapi_drm_picture.cc

Issue 2148983002: gpu: Take surface handle into account when importing buffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: avoid crash in DrmDeviceManager::GetDrmDevice when passed invalid widget Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/ipc/service/gpu_memory_buffer_factory_surface_texture.cc ('k') | ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/gpu/vaapi_drm_picture.cc

diff --git a/media/gpu/vaapi_drm_picture.cc b/media/gpu/vaapi_drm_picture.cc

index 3de36d3ca362b0ede8872484ba9a08d31425afdd..1aaa8800ff877fdeb7c55d6c2b980fb0ec639a5c 100644

--- a/media/gpu/vaapi_drm_picture.cc

+++ b/media/gpu/vaapi_drm_picture.cc

@@ -123,7 +123,8 @@ bool VaapiDrmPicture::ImportGpuMemoryBufferHandle(

ui::SurfaceFactoryOzone* factory = platform->GetSurfaceFactoryOzone();

// CreateNativePixmapFromHandle() will take ownership of the handle.

pixmap_ = factory->CreateNativePixmapFromHandle(

- size_, format, gpu_memory_buffer_handle.native_pixmap_handle);

+ gfx::kNullAcceleratedWidget, size_, format,

+ gpu_memory_buffer_handle.native_pixmap_handle);

if (!pixmap_) {

DVLOG(1) << "Failed creating a pixmap from a native handle";

return false;

« no previous file with comments | « gpu/ipc/service/gpu_memory_buffer_factory_surface_texture.cc ('k') | ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc » ('j') | no next file with comments »