gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc - Issue 2148983002: gpu: Take surface handle into account when importing buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc

Issue 2148983002: gpu: Take surface handle into account when importing buffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: avoid crash in DrmDeviceManager::GetDrmDevice when passed invalid widget Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.h ('k') | gpu/ipc/service/gpu_memory_buffer_factory_surface_texture.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc

diff --git a/gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc b/gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc

index 35e77b3e4b1e41a979eeb8d97889c088da3ca54d..a6fe210ec306eda4a8e1314dc82dbb9e47022596 100644

--- a/gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc

+++ b/gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc

@@ -55,12 +55,13 @@ GpuMemoryBufferFactoryOzoneNativePixmap::CreateImageForGpuMemoryBuffer(

const gfx::Size& size,

gfx::BufferFormat format,

unsigned internalformat,

- int client_id) {

+ int client_id,

+ SurfaceHandle surface_handle) {

DCHECK_EQ(handle.type, gfx::OZONE_NATIVE_PIXMAP);

scoped_refptr<ui::NativePixmap> pixmap =

ui::OzonePlatform::GetInstance()

->GetSurfaceFactoryOzone()

- ->CreateNativePixmapFromHandle(size, format,

+ ->CreateNativePixmapFromHandle(surface_handle, size, format,

handle.native_pixmap_handle);

if (!pixmap.get()) {

DLOG(ERROR) << "Failed to create pixmap from handle";