BubbleFrameView: add top padding even when close button is hidden

ui/views/bubble/bubble_frame_view.cc

Index: ui/views/bubble/bubble_frame_view.cc
diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc
index 43bac842f05e438b5a8001e005c41d2ddc20ddbf..0017365c20875f67427f7264ab5354326784b215 100644
--- a/ui/views/bubble/bubble_frame_view.cc
+++ b/ui/views/bubble/bubble_frame_view.cc
@@ -244,7 +244,8 @@ gfx::Insets BubbleFrameView::GetInsets() const {
   const bool has_title = icon_height > 0 || label_height > 0;
   const int title_padding = has_title ? title_margins_.height() : 0;
   const int title_height = std::max(icon_height, label_height) + title_padding;
-  const int close_height = close_->visible() ? close_->height() : 0;
+  const int close_height =
+      close_->visible() || !has_title ? close_->height() : 0;

[msw, 2016/07/13 19:23:44]

Consider leaving close_height as-is and doing something like:
  const int min_height = ...;
  insets += gfx::Insets(std::max({title_height, close_height, min_height}), 0,
0, 0);
Using ui/views/layout/layout_constants.h or close_->height() for min.

[Elly Fong-Jones, 2016/07/13 20:18:22]

Done.

   insets += gfx::Insets(std::max(title_height, close_height), 0, 0, 0);
   return insets;
 }