Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2148923002: X11: Add new windows to the front of the stacking list (Closed)

Created:
4 years, 5 months ago by Tom (Use chromium acct)
Modified:
4 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

X11: Add new windows to the front of the stacking list According to the X11 doc: "The created window is placed on top in the stacking order with respect to siblings." Since all windows that DWTHX11 creates are children of the root window, they are all siblings, so new windows should instead be added to the front of the stacking list. BUG=556048 Committed: https://crrev.com/2096e29162feabdc2a62200c2c30bf9650c7aed3 Cr-Commit-Position: refs/heads/master@{#405225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom (Use chromium acct)
4 years, 5 months ago (2016-07-13 17:38:56 UTC) #4
Elliot Glaysher
lgtm
4 years, 5 months ago (2016-07-13 17:43:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148923002/1
4 years, 5 months ago (2016-07-13 17:48:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 19:40:01 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:42:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2096e29162feabdc2a62200c2c30bf9650c7aed3
Cr-Commit-Position: refs/heads/master@{#405225}

Powered by Google App Engine
This is Rietveld 408576698