Reland: Improve ios/web/public/test/web_js_test.h

Reland: Improve ios/web/public/test/web_js_test.h

The relanding fix is replacing DCHECK_NSEQ with EXPECT_NSEQ.

The original patch from https://codereview.chromium.org/2148723003/ is patch
set 1 here, the rest is the fix.

Original description:

This CL does some minor changes to web_js_test.h based on eugenebut's
recommendations in https://codereview.chromium.org/2150513002/#msg21.

R=eugenebut@chromium.org
BUG=627775
Committed: https://crrev.com/a96a1fa7525f6e15a4669da14be166ec422fd9bd
Cr-Commit-Position: refs/heads/master@{#405304}

[vabr (Chromium), 2016-07-13 20:48:21]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[vabr (Chromium), 2016-07-13 20:48:43]

Hi Eugene, PTAL. Sorry for this back and forth!

Vaclav

[commit-bot: I haz the power, 2016-07-13 20:49:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-07-13 21:11:29]

lgtm and no worries. I suggested you incorrect macro :)

[vabr (Chromium), 2016-07-13 21:24:19]

On 2016/07/13 21:11:29, Eugene But wrote:
> lgtm and no worries. I suggested you incorrect macro :)

Thanks!

In addition to the upstream trybots, I also did a twosided tryjob now, and it
passed on smoke. So I'll land and notify the sheriff about what to revert if it
breaks again. :)

Vaclav

[vabr (Chromium), 2016-07-13 21:24:26]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2016-07-13 21:24:30]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-07-13 21:25:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:45:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-13 21:45:16]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 21:48:09]

Description was changed from

==========
Reland: Improve ios/web/public/test/web_js_test.h

The relanding fix is replacing DCHECK_NSEQ with EXPECT_NSEQ.

The original patch from https://codereview.chromium.org/2148723003/ is patch
set 1 here, the rest is the fix.

Original description:

This CL does some minor changes to web_js_test.h based on eugenebut's
recommendations in https://codereview.chromium.org/2150513002/#msg21.

R=eugenebut@chromium.org
BUG=627775
==========

to

==========
Reland: Improve ios/web/public/test/web_js_test.h

The relanding fix is replacing DCHECK_NSEQ with EXPECT_NSEQ.

The original patch from https://codereview.chromium.org/2148723003/ is patch
set 1 here, the rest is the fix.

Original description:

This CL does some minor changes to web_js_test.h based on eugenebut's
recommendations in https://codereview.chromium.org/2150513002/#msg21.

R=eugenebut@chromium.org
BUG=627775

Committed: https://crrev.com/a96a1fa7525f6e15a4669da14be166ec422fd9bd
Cr-Commit-Position: refs/heads/master@{#405304}
==========

[commit-bot: I haz the power, 2016-07-13 21:48:09]

Patchset 3 (id:??) landed as
https://crrev.com/a96a1fa7525f6e15a4669da14be166ec422fd9bd
Cr-Commit-Position: refs/heads/master@{#405304}