[system-health] Add full Google Search story to the System Health story sets

[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'search:portal' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kwQEHMwI/#gid=712129109).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/d6d935821c3afc9c0ce21e2a74a5411b59cb3c66
Cr-Commit-Position: refs/heads/master@{#407225}

[petrcermak, 2016-07-13 15:47:15]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com

[petrcermak, 2016-07-13 15:47:16]

PTAL.

Thanks,
Petr

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/single_page_stories.py (right):

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/single_page_stories.py:92: class
SearchGoogleStory(_SinglePageStory):
I'll move this to a separate file (search_stories.py) after Ulan's patch lands.

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/single_page_stories.py:93: NAME =
'search:search:google'
I'm still not completely sure about the names:

1. I'm thinking about dropping the second component of the name (search, social,
games, ...) as it is always unambiguously implied by the third component.

2. As explained in
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...,
I would like to have gradual stories as well:

  * load (currently 'load:*')
  * load -> type
  * load -> type -> return
  * load -> type -> return -> scroll
  * load -> type -> return -> scroll -> click (currently 'search:*')

However, I'm not completely sure how this maps onto story names and if it's even
feasible (in terms of benchmark running time).

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/single_page_stories.py:122: while
action_runner.EvaluateJavaScript(result_visible_expression):
Note that we can't a single RepeatableBrowserDrivenScroll (with repeat_count >
1) since it would scroll too far (due to fling).

[nednguyen, 2016-07-13 16:03:24]

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/single_page_stories.py (right):

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/single_page_stories.py:93: NAME =
'search:search:google'
On 2016/07/13 15:47:15, petrcermak wrote:
> I'm still not completely sure about the names:
> 
> 1. I'm thinking about dropping the second component of the name (search,
social,
> games, ...) as it is always unambiguously implied by the third component.
> 
> 2. As explained in
>
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...,
> I would like to have gradual stories as well:
> 
>   * load (currently 'load:*')
>   * load -> type
>   * load -> type -> return
>   * load -> type -> return -> scroll
>   * load -> type -> return -> scroll -> click (currently 'search:*')
> 
> However, I'm not completely sure how this maps onto story names and if it's
even
> feasible (in terms of benchmark running time).
> 

This seems like it a type of browsing stories so should go into
browsing_stories.py?

[petrcermak, 2016-07-14 13:19:59]

Description was changed from

==========
[system-health] Add full Google Search story to the System Health story sets

This patch adds a single 'search:search:google' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
==========

to

==========
[system-health] Add Google Search browsing to the System Health story sets

This patch adds a single 'browse:search:google' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
==========

[petrcermak, 2016-07-14 13:20:15]

petrcermak@chromium.org changed reviewers:
+ ulan@chromium.org

[petrcermak, 2016-07-14 13:20:16]

PTAL.

Thanks,
Petr

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/single_page_stories.py (right):

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/single_page_stories.py:93: NAME =
'search:search:google'
On 2016/07/13 16:03:24, nednguyen wrote:
> On 2016/07/13 15:47:15, petrcermak wrote:
> > I'm still not completely sure about the names:
> > 
> > 1. I'm thinking about dropping the second component of the name (search,
> social,
> > games, ...) as it is always unambiguously implied by the third component.
> > 
> > 2. As explained in
> >
>
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...,
> > I would like to have gradual stories as well:
> > 
> >   * load (currently 'load:*')
> >   * load -> type
> >   * load -> type -> return
> >   * load -> type -> return -> scroll
> >   * load -> type -> return -> scroll -> click (currently 'search:*')
> > 
> > However, I'm not completely sure how this maps onto story names and if it's
> even
> > feasible (in terms of benchmark running time).
> > 
> 
> This seems like it a type of browsing stories so should go into
> browsing_stories.py? 

Done.

[petrcermak, 2016-07-14 13:22:43]

Description was changed from

==========
[system-health] Add Google Search browsing to the System Health story sets

This patch adds a single 'browse:search:google' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
==========

to

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'browse:search:google' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
==========

[nednguyen, 2016-07-14 13:25:17]

nednguyen@google.com changed reviewers:
- ulan@chromium.org

[nednguyen, 2016-07-14 13:25:17]

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/single_page_stories.py (right):

https://codereview.chromium.org/2148843002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/single_page_stories.py:93: NAME =
'search:search:google'
On 2016/07/13 at 16:03:24, nednguyen wrote:
> On 2016/07/13 15:47:15, petrcermak wrote:
> > I'm still not completely sure about the names:
> > 
> > 1. I'm thinking about dropping the second component of the name (search,
social,
> > games, ...) as it is always unambiguously implied by the third component.
> > 
> > 2. As explained in
> >
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...,
> > I would like to have gradual stories as well:
> > 
> >   * load (currently 'load:*')
> >   * load -> type
> >   * load -> type -> return
> >   * load -> type -> return -> scroll
> >   * load -> type -> return -> scroll -> click (currently 'search:*')
> > 
> > However, I'm not completely sure how this maps onto story names and if it's
even
> > feasible (in terms of benchmark running time).
> > 
> 
> This seems like it a type of browsing stories so should go into
browsing_stories.py?

Now that I know search is a major activity that people spend time doing online,
I think it's ok to put seach stories to their own group instead of merging to
browsing.
When we talk about search in general, I think there are quite a few major
scenarios that I can think about:
+ search for news
+ search for video (google video search, youtube)
+ search for images
+ search for location 
+ search for a product (e.g: google shopping/bing/amazon/ebay)
+ search for a person in social network

Based on these different themes, we can name things the following way:
"search:news:google", "search:video:bing", "search:product:amazon",...

What do you think?

[petrcermak, 2016-07-19 14:26:17]

On 2016/07/14 13:25:17, nednguyen wrote:
> Now that I know search is a major activity that people spend time doing
online,
> I think it's ok to put seach stories to their own group instead of merging to
> browsing.
> When we talk about search in general, I think there are quite a few major
> scenarios that I can think about:
> + search for news
> + search for video (google video search, youtube)
> + search for images
> + search for location 
> + search for a product (e.g: google shopping/bing/amazon/ebay)
> + search for a person in social network
> 
> Based on these different themes, we can name things the following way:
> "search:news:google", "search:video:bing", "search:product:amazon",...
> 
> What do you think?

I agree, but I wouldn't classify "google" et all as "news". Maybe
search:portal:google (and rename load:search:google to
load:portal:google)?

Alternatively, we could completely drop the middle part of the name,
e.g. load:google, search:google, ... The only downside here is that we'd
have to ask Annie to rename old values stored on the dashboard.

Note that I uploaded a new patch (which depends on
https://codereview.chromium.org/2159733002/).

Petr

[nednguyen, 2016-07-20 12:48:41]

On 2016/07/19 14:26:17, petrcermak wrote:
> On 2016/07/14 13:25:17, nednguyen wrote:
> > Now that I know search is a major activity that people spend time doing
> online,
> > I think it's ok to put seach stories to their own group instead of merging
to
> > browsing.
> > When we talk about search in general, I think there are quite a few major
> > scenarios that I can think about:
> > + search for news
> > + search for video (google video search, youtube)
> > + search for images
> > + search for location 
> > + search for a product (e.g: google shopping/bing/amazon/ebay)
> > + search for a person in social network
> > 
> > Based on these different themes, we can name things the following way:
> > "search:news:google", "search:video:bing", "search:product:amazon",...
> > 
> > What do you think?
> 
> I agree, but I wouldn't classify "google" et all as "news". Maybe
> search:portal:google (and rename load:search:google to
> load:portal:google)?
> 
> Alternatively, we could completely drop the middle part of the name,
> e.g. load:google, search:google, ... The only downside here is that we'd
> have to ask Annie to rename old values stored on the dashboard.

The current 3 parts naming scheme is nice, I think let keep it that way. So to
clarify, I think the 3 parts are:
<user intention>:<category of target>:<domain>?

"search:portal:google" sgtm. Though I can see we later add an AMP swiping case
later as search:news:google 

> 
> Note that I uploaded a new patch (which depends on
> https://codereview.chromium.org/2159733002/).
> 
> Petr

[nednguyen, 2016-07-20 16:02:03]

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/loading_stories.py (right):

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/loading_stories.py:24: URL =
'https://www.google.co.uk/'
Is this rebase error?

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/searching_stories.py (right):

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/searching_stories.py:31: # TODO(petrcermak):
Turn this into a proper Telemetry API (ScrollToElement).
Yeah, I encounter this situation a lot too ~_~

[petrcermak, 2016-07-20 19:08:21]

On 2016/07/20 12:48:41, nednguyen wrote:
> The current 3 parts naming scheme is nice, I think let keep it that way. So to
> clarify, I think the 3 parts are:
> <user intention>:<category of target>:<domain>?
> 
> "search:portal:google" sgtm. Though I can see we later add an AMP swiping case
> later as search:news:google 

OK. I'll change the name to "search:portal:google". Apart from that, are you
happy with this patch (should I upload WPRs)?

I'll rename "load:search:*" to "load:portal:{google, ...}" and
"load:shopping:{amazon, ...}" in a separate patch, but I first want to check
with Annie that she can handle the renaming of old values.

Thanks,
Petr

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/loading_stories.py (right):

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/loading_stories.py:24: URL =
'https://www.google.co.uk/'
On 2016/07/20 16:02:02, nednguyen wrote:
> Is this rebase error?

No, it's intentional. The load story should use the same URL as the new browse
story. This is in line with Ulan's previous change where he changed the URLs of
several loading stories so that they would match the URLs of his browsing
stories.

[nednguyen, 2016-07-20 20:43:44]

lgtm

[nednguyen, 2016-07-20 20:44:25]

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/searching_stories.py (right):

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/searching_stories.py:9: NAME =
'search:search:google'
search:portal:google?

[petrcermak, 2016-07-22 16:16:25]

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
File tools/perf/page_sets/system_health/searching_stories.py (right):

https://codereview.chromium.org/2148843002/diff/40001/tools/perf/page_sets/sy...
tools/perf/page_sets/system_health/searching_stories.py:9: NAME =
'search:search:google'
On 2016/07/20 20:44:25, nednguyen wrote:
> search:portal:google?

Done.

[petrcermak, 2016-07-22 16:16:41]

The CQ bit was checked by petrcermak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 16:16:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-07-22 16:18:04]

Description was changed from

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'browse:search:google' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
==========

to

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'browse:search:google' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

[petrcermak, 2016-07-22 16:18:18]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-07-22 16:18:29]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-07-22 16:18:29]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2148843002/#ps60001
(title: "Final changes")

[commit-bot: I haz the power, 2016-07-22 16:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-07-22 16:19:54]

Description was changed from

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'browse:search:google' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'search:portal' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

[petrcermak, 2016-07-22 16:20:06]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-07-22 16:20:14]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-07-22 16:20:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 17:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 17:12:40]

Failed to apply patch for tools/perf/page_sets/data/system_health_mobile.json:
While running git apply --index -3 -p1;
  error: patch failed: tools/perf/page_sets/data/system_health_mobile.json:94
  Falling back to three-way merge...
  Applied patch to 'tools/perf/page_sets/data/system_health_mobile.json' with
conflicts.
  U tools/perf/page_sets/data/system_health_mobile.json

Patch:       tools/perf/page_sets/data/system_health_mobile.json
Index: tools/perf/page_sets/data/system_health_mobile.json
diff --git a/tools/perf/page_sets/data/system_health_mobile.json
b/tools/perf/page_sets/data/system_health_mobile.json
index
ad01029fbf5071a3a72c0a48737fab558a6e2cb0..91930a77cf0047d3dcc1525398085df6c3a19f6c
100644
--- a/tools/perf/page_sets/data/system_health_mobile.json
+++ b/tools/perf/page_sets/data/system_health_mobile.json
@@ -4,7 +4,6 @@
             "load:search:amazon",
             "load:search:baidu",
             "load:search:yandex",
-            "load:search:google",
             "load:search:taobao",
             "load:search:ebay",
             "load:search:yahoo"
@@ -94,6 +93,10 @@
         ],
         "system_health_mobile_025.wpr": [
             "browse:news:flipboard"
+        ],
+        "system_health_mobile_028.wpr": [
+            "load:search:google",
+            "search:portal:google"
         ]
     },
     "description": "Describes the Web Page Replay archives for a story set.
Don't edit by hand! Use record_wpr for updating."

[petrcermak, 2016-07-22 17:20:00]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-07-22 17:20:00]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2148843002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-22 17:20:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 19:12:21]

Description was changed from

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'search:portal' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'search:portal' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

[commit-bot: I haz the power, 2016-07-22 19:12:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-22 19:13:36]

Description was changed from

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'search:portal' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[system-health] Add Google Search browsing story to the System Health story sets

This patch adds a single 'search:portal' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kw...).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/d6d935821c3afc9c0ce21e2a74a5411b59cb3c66
Cr-Commit-Position: refs/heads/master@{#407225}
==========

[commit-bot: I haz the power, 2016-07-22 19:13:38]

Patchset 5 (id:??) landed as
https://crrev.com/d6d935821c3afc9c0ce21e2a74a5411b59cb3c66
Cr-Commit-Position: refs/heads/master@{#407225}

[Mark P, 2016-07-22 20:48:19]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2173943003/ by mpearson@chromium.org.

The reason for reverting is: 
I see a failure for
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.search:portal:google
on
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

This is obviously related.

Only one run with this patch has been completed thus far.  Either this change
caused the failure or, even if not, this change has caused this test to become
flaky (I don't see any failures before this).
.