Componentize zombies to silence ObjC runtime errors in component builds

components/crash/core/common/BUILD.gn

Index: components/crash/core/common/BUILD.gn
diff --git a/components/crash/core/common/BUILD.gn b/components/crash/core/common/BUILD.gn
index 3714a2380a5421b85626d2d8143760f2ef4870b9..64e64ffb6e6982a3ae85bec52452e3775259fe88 100644
--- a/components/crash/core/common/BUILD.gn
+++ b/components/crash/core/common/BUILD.gn
@@ -2,7 +2,17 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-static_library("common") {
+group("common") {
+  public_deps = [
+    ":crash_keys",
+  ]
+
+  if (is_mac || is_ios) {
+    public_deps += [ ":zombies" ]
+  }
+}
+
+static_library("crash_keys") {
   sources = [
     "crash_keys.cc",
     "crash_keys.h",
@@ -11,12 +21,23 @@ static_library("common") {
   deps = [
     "//base",
   ]
+}
 
-  if (is_mac || is_ios) {
-    sources += [
+if (is_mac || is_ios) {
+  component("zombies") {
+    sources = [

[Robert Sesek, 2016/07/13 22:15:14]

List the crash_export.h here.

[Sidney San Martín, 2016/07/13 22:32:46]

Done.

       "objc_zombie.h",
       "objc_zombie.mm",
     ]
+
+    defines = [ "COMPONENTS_CRASH_CORE_COMMON_CRASH_IMPLEMENTATION" ]

[Robert Sesek, 2016/07/13 22:15:14]

If you wanted a shorter string, CRASH_CORE_COMMON_IMPLEMENTATION is fine.

[Sidney San Martín, 2016/07/13 22:32:46]

Done.

+
+    deps = [
+      ":crash_keys",
+      "//base",
+    ]
+
+    libs = [ "Foundation.framework" ]
   }
 }