Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: components/crash/core/common/BUILD.gn

Issue 2148803003: Componentize zombies to silence ObjC runtime errors in component builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 static_library("common") { 5 group("common") {
6 public_deps = [
7 ":crash_keys",
8 ]
9
10 if (is_mac || is_ios) {
11 public_deps += [ ":zombies" ]
12 }
13 }
14
15 static_library("crash_keys") {
6 sources = [ 16 sources = [
7 "crash_keys.cc", 17 "crash_keys.cc",
8 "crash_keys.h", 18 "crash_keys.h",
9 ] 19 ]
10 20
11 deps = [ 21 deps = [
12 "//base", 22 "//base",
13 ] 23 ]
24 }
14 25
15 if (is_mac || is_ios) { 26 if (is_mac || is_ios) {
16 sources += [ 27 component("zombies") {
28 sources = [
Robert Sesek 2016/07/13 20:40:58 List the crash_export.h here, too, after it is mov
17 "objc_zombie.h", 29 "objc_zombie.h",
18 "objc_zombie.mm", 30 "objc_zombie.mm",
19 ] 31 ]
32
33 defines = [ "CRASH_IMPLEMENTATION" ]
34
35 deps = [
36 ":crash_keys",
37 "//base",
38 ]
39
40 libs = [ "Foundation.framework" ]
20 } 41 }
21 } 42 }
22 43
23 source_set("unit_tests") { 44 source_set("unit_tests") {
24 testonly = true 45 testonly = true
25 sources = [ 46 sources = [
26 "crash_keys_unittest.cc", 47 "crash_keys_unittest.cc",
27 ] 48 ]
28 49
29 deps = [ 50 deps = [
30 ":common", 51 ":common",
31 "//base", 52 "//base",
32 "//testing/gtest", 53 "//testing/gtest",
33 ] 54 ]
34 55
35 if (is_mac || is_ios) { 56 if (is_mac || is_ios) {
36 sources += [ "objc_zombie_unittest.mm" ] 57 sources += [ "objc_zombie_unittest.mm" ]
37 } 58 }
38 } 59 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698