components/crash/core/DEPS - Issue 2148803003: Componentize zombies to silence ObjC runtime errors in component builds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/crash/core/DEPS

Issue 2148803003: Componentize zombies to silence ObjC runtime errors in component builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # This component is shared with the Chrome OS build, so it's important to limit	1 # This component is shared with the Chrome OS build, so it's important to limit

2 # dependencies to a minimal set.	2 # dependencies to a minimal set.

3 include_rules = [	3 include_rules = [

4 "-components",	4 "-components",

5 "+components/crash/core",	5 "+components/crash",
	Sidney San Martín 2016/07/13 16:45:23 I'm not sure if this is the right move here — what I'm not sure if this is the right move here — what do you think? Robert Sesek 2016/07/13 20:40:58 I don't see any other layered components (those wi Show quoted text On 2016/07/13 16:45:23, Sidney San Martín wrote: > I'm not sure if this is the right move here — what do you think? I don't see any other layered components (those with a core/ and content/ directory http://dev.chromium.org/developers/design-documents/layered-components-design) with _export macros. So let's move the crash_export.h file closer to where it's required, and that obviate this. Move components/crash/crash_export.h into components/crash/core/common. Sidney San Martín 2016/07/13 21:11:52 Done. Show quoted text On 2016/07/13 20:40:58, Robert Sesek wrote: > On 2016/07/13 16:45:23, Sidney San Martín wrote: > > I'm not sure if this is the right move here — what do you think? > > I don't see any other layered components (those with a core/ and content/ > directory > http://dev.chromium.org/developers/design-documents/layered-components-design) > with _export macros. > > So let's move the crash_export.h file closer to where it's required, and that > obviate this. Move components/crash/crash_export.h into > components/crash/core/common. Done.
6 "-net",	6 "-net",

7 ]	7 ]

OLD	NEW

« no previous file with comments | « no previous file | components/crash/core/common/BUILD.gn » ('j') | components/crash/core/common/BUILD.gn » ('J')