Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2148793007: MD Settings: Fix search engines drop-down menu. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix search engines drop-down menu. The same change fixes two issues. 1) No more showing of unnecessary horizontal scrollbar. 2) Allow using "Enter" key to change dropdown selection. BUG=628499, 626989 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ada53fa9511af7324edad932dacd5157a70891b9 Cr-Commit-Position: refs/heads/master@{#405789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/settings/search_page/search_page.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dpapad
Screenshots: http://imgur.com/a/sFZTE.
4 years, 5 months ago (2016-07-15 17:27:18 UTC) #5
Dan Beam
lgtm
4 years, 5 months ago (2016-07-15 17:28:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148793007/1
4 years, 5 months ago (2016-07-15 17:37:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 18:01:16 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 18:02:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ada53fa9511af7324edad932dacd5157a70891b9
Cr-Commit-Position: refs/heads/master@{#405789}

Powered by Google App Engine
This is Rietveld 408576698