[Remoting Android] Cursor & Cursor Feedback for OpenGL Renderer

remoting/client/gl_math.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/client/gl_math.h"
+
+#include <sstream>
+
+namespace {
+
+// | m0, m1, m2, |   | Scale_x  0        Offset_x |
+// | m3, m4, m5, | = | 0        Scale_y  Offset_y |
+// | m6, m7, m8  |   | 0        0        1        |
+
+const int kXScaleKey = 0;
+const int kYScaleKey = 4;
+const int kXOffsetKey = 2;
+const int kYOffsetKey = 5;
+
+}

[Sergey Ulanov, 2016/07/19 00:42:48]

  // namespace 

[Yuwei, 2016/07/19 20:34:23]

Done.

+
+namespace remoting {
+
+void NormalizeTransformationMatrix(std::array<float, 9>& mat,
+                                   int view_width,
+                                   int view_height,
+                                   int canvas_width,
+                                   int canvas_height) {
+  mat[kXScaleKey] = canvas_width * mat[kXScaleKey] / view_width;
+  mat[kYScaleKey] = canvas_height * mat[kYScaleKey] / view_height;
+  mat[kXOffsetKey] /= view_width;
+  mat[kYOffsetKey] /= view_height;
+}
+
+void FillRectangleVertexPositions(std::array<float, 8>& positions,
+                                  float left,
+                                  float top,
+                                  float width,
+                                  float height) {
+  positions[0] = left;
+  positions[2] = left;
+  positions[4] = left + width;
+  positions[6] = left + width;
+
+  positions[1] = top;

[Sergey Ulanov, 2016/07/19 00:42:48]

I think it would be more readable if you filled in the array in order from 0 to
7

[Yuwei, 2016/07/19 20:34:23]

Done.

+  positions[3] = top + height;
+  positions[5] = top;
+  positions[7] = top + height;
+}
+
+std::string MatrixToString(const float* mat, int num_rows, int num_cols) {
+  std::ostringstream outstream;
+  outstream << "[\n";
+  for (int i = 0; i < num_rows; i++) {
+    for (int j = 0; j < num_cols; j++) {
+      outstream << mat[i*num_cols + j] << ", ";

[Sergey Ulanov, 2016/07/19 00:42:48]

spaces around * please. (git cl format?)

[Yuwei, 2016/07/19 20:34:23]

Done.

+    }
+    outstream << "\n";
+  }
+  outstream << "]";
+  return outstream.str();
+}
+
+}  // namespace remoting