Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: src/runtime/runtime-internal.cc

Issue 2148743004: WIP: wasm oob trap handling experiments (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Undoing spurious changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/x64/instruction-selector-x64.cc ('k') | src/runtime/runtime-wasm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-internal.cc
diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc
index db2aa01ea8db022d2c35bc7259783dc78d08eec2..ddb1ba67c38f2ac8d9f05db0c2c86c604a1a0a32 100644
--- a/src/runtime/runtime-internal.cc
+++ b/src/runtime/runtime-internal.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/runtime/runtime-utils.h"
+#include <setjmp.h>
#include <memory>
@@ -16,6 +16,7 @@
#include "src/messages.h"
#include "src/parsing/parse-info.h"
#include "src/parsing/parser.h"
+#include "src/runtime/runtime-utils.h"
#include "src/wasm/wasm-module.h"
namespace v8 {
@@ -86,14 +87,12 @@ RUNTIME_FUNCTION(Runtime_Throw) {
return isolate->Throw(args[0]);
}
-
RUNTIME_FUNCTION(Runtime_ReThrow) {
HandleScope scope(isolate);
DCHECK(args.length() == 1);
return isolate->ReThrow(args[0]);
}
-
RUNTIME_FUNCTION(Runtime_ThrowStackOverflow) {
SealHandleScope shs(isolate);
DCHECK_LE(0, args.length());
@@ -110,7 +109,7 @@ RUNTIME_FUNCTION(Runtime_ThrowWasmError) {
// For wasm traps, the byte offset (a.k.a source position) can not be
// determined from relocation info, since the explicit checks for traps
- // converge in one singe block which calls this runtime function.
+ // converge in one single block which calls this runtime function.
// We hence pass the byte offset explicitely, and patch it into the top-most
// frame (a wasm frame) on the collected stack trace.
// TODO(wasm): This implementation is temporary, see bug #5007:
« no previous file with comments | « src/compiler/x64/instruction-selector-x64.cc ('k') | src/runtime/runtime-wasm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698