Issue 2148743002: Rietveld: don't show (dry run) after commit box is unchecked.

Issue 2148743002: Rietveld: don't show (dry run) after commit box is unchecked. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)

Modified:
4 years, 5 months ago

Reviewers:
Michael Achenbach

CC:
chromium-reviews, infra-reviews+infra_chromium.org

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

Rietveld: don't show (dry run) after commit box is unchecked. This is workaround because of the bug in CQ committed yesterday that sent cq_dry_run=True when unchecking the commit box. BUG=626427 Committed: https://chromium.googlesource.com/infra/infra/+/c454ca1055de42ef396bfbc6fd7ebe5ff502ee74

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	appengine/chromium_rietveld/templates/patchset.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (6 generated)

tandrii(chromium)

Internal counterpart is https://chromereviews.googleplex.com/469727017

4 years, 5 months ago (2016-07-13 10:23:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148743002/1

4 years, 5 months ago (2016-07-13 10:27:54 UTC) #8

commit-bot: I haz the power

4 years, 5 months ago (2016-07-13 11:23:46 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/c454ca1055de42ef396bfbc6fd7eb...