Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2148733005: Remove test coverage of document.timeline.getAnimations() (Closed)

Created:
4 years, 5 months ago by alancutter (OOO until 2018)
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove test coverage of document.timeline.getAnimations() DocumentTimeline no longer has getAnimations() in the spec. http://w3c.github.io/web-animations/#the-documenttimeline-interface Removing test coverage of something unspecced is part of upstreaming the test to WPTs. This is a reupload of http://crrev.com/2137383002#ps20001 with updated test expectations. BUG=623437 Committed: https://crrev.com/813dc6d714d81f658e24afde116b0e8f673eb660 Cr-Commit-Position: refs/heads/master@{#405435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -152 lines) Patch
D third_party/WebKit/LayoutTests/web-animations-api/w3c/get-animation-players.html View 1 chunk +0 lines, -108 lines 0 comments Download
A + third_party/WebKit/LayoutTests/web-animations-api/w3c/get-animations.html View 2 chunks +26 lines, -44 lines 0 comments Download
A third_party/WebKit/LayoutTests/web-animations-api/w3c/get-animations-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alancutter (OOO until 2018)
4 years, 5 months ago (2016-07-14 03:34:53 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-14 03:43:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148733005/1
4 years, 5 months ago (2016-07-14 03:43:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 04:56:03 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 04:57:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/813dc6d714d81f658e24afde116b0e8f673eb660
Cr-Commit-Position: refs/heads/master@{#405435}

Powered by Google App Engine
This is Rietveld 408576698