Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2148733003:
Avoided rentry to EventSender::FinishDragAndDrop. (Closed)
|
Created:
4 years, 5 months ago by mustaq Modified:
4 years, 5 months ago Reviewers:
Rick Byers CC:
chromium-reviews, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoided rentry to EventSender::FinishDragAndDrop.
Avoided rentry to EventSender::FinishDragAndDrop to fix
a ClusterFuzz crash. The test uses an EventSender sequence
to drag from one div to another. The sequence ends with a
mouseup, but the drag target also fires a mouseup on
dragend. While the first mouseup was still processing a
drag-drop at EventSender::FinishDragAndDrop, the second
mouseup triggered another call to
EventSender::FinishDragAndDrop, causing a premature call
to WebViewImpl::dragTargetDragEnterOrOver with the crash.
See the bug for a minimal test case.
BUG=627340
Committed: https://crrev.com/f2d3dd78f333c287f6fcb44738bcf399b7af8515
Cr-Commit-Position: refs/heads/master@{#405510}
Patch Set 1 #Patch Set 2 : Moved the state-reset ahead. #Patch Set 3 : Moved back state-reset back on test failures. #Messages
Total messages: 23 (14 generated)
The CQ bit was checked by mustaq@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Avoided rentry to EventSender::FinishDragAndDrop. BUG=627340 ========== to ========== Avoided rentry to EventSender::FinishDragAndDrop. Avoided rentry to EventSender::FinishDragAndDrop to fix a ClusterFuzz crash. BUG=627340 ==========
mustaq@chromium.org changed reviewers: + rbyers@chromium.org
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The fix LGTM, but can you please add a bit more detail to the CL description about how/why this fixes a problem? It's not at all obvious to me just looking at the diff (and someone else looking at the commit history may need to understand it in the future).
Description was changed from ========== Avoided rentry to EventSender::FinishDragAndDrop. Avoided rentry to EventSender::FinishDragAndDrop to fix a ClusterFuzz crash. BUG=627340 ========== to ========== Avoided rentry to EventSender::FinishDragAndDrop. Avoided rentry to EventSender::FinishDragAndDrop to fix a ClusterFuzz crash. The test uses an EventSender sequence to drag from one div to another. The sequence ends with a mouseup, but the drag target also fires a mouseup on dragend. While the first mouseup was still processing a drag-drop at EventSender::FinishDragAndDrop, the second mouseup triggered another call to EventSender::FinishDragAndDrop, causing a premature call to WebViewImpl::dragTargetDragEnterOrOver with the crash. See the bug for a minimal test case. BUG=627340 ==========
On 2016/07/14 14:00:14, Rick Byers wrote: > The fix LGTM, but can you please add a bit more detail to the CL description > about how/why this fixes a problem? It's not at all obvious to me just looking > at the diff (and someone else looking at the commit history may need to > understand it in the future). Done.
The CQ bit was checked by mustaq@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org Link to the patchset: https://codereview.chromium.org/2148733003/#ps20001 (title: "Moved the state-reset ahead.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mustaq@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org Link to the patchset: https://codereview.chromium.org/2148733003/#ps40001 (title: "Moved back state-reset back on test failures.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Avoided rentry to EventSender::FinishDragAndDrop. Avoided rentry to EventSender::FinishDragAndDrop to fix a ClusterFuzz crash. The test uses an EventSender sequence to drag from one div to another. The sequence ends with a mouseup, but the drag target also fires a mouseup on dragend. While the first mouseup was still processing a drag-drop at EventSender::FinishDragAndDrop, the second mouseup triggered another call to EventSender::FinishDragAndDrop, causing a premature call to WebViewImpl::dragTargetDragEnterOrOver with the crash. See the bug for a minimal test case. BUG=627340 ========== to ========== Avoided rentry to EventSender::FinishDragAndDrop. Avoided rentry to EventSender::FinishDragAndDrop to fix a ClusterFuzz crash. The test uses an EventSender sequence to drag from one div to another. The sequence ends with a mouseup, but the drag target also fires a mouseup on dragend. While the first mouseup was still processing a drag-drop at EventSender::FinishDragAndDrop, the second mouseup triggered another call to EventSender::FinishDragAndDrop, causing a premature call to WebViewImpl::dragTargetDragEnterOrOver with the crash. See the bug for a minimal test case. BUG=627340 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Avoided rentry to EventSender::FinishDragAndDrop. Avoided rentry to EventSender::FinishDragAndDrop to fix a ClusterFuzz crash. The test uses an EventSender sequence to drag from one div to another. The sequence ends with a mouseup, but the drag target also fires a mouseup on dragend. While the first mouseup was still processing a drag-drop at EventSender::FinishDragAndDrop, the second mouseup triggered another call to EventSender::FinishDragAndDrop, causing a premature call to WebViewImpl::dragTargetDragEnterOrOver with the crash. See the bug for a minimal test case. BUG=627340 ========== to ========== Avoided rentry to EventSender::FinishDragAndDrop. Avoided rentry to EventSender::FinishDragAndDrop to fix a ClusterFuzz crash. The test uses an EventSender sequence to drag from one div to another. The sequence ends with a mouseup, but the drag target also fires a mouseup on dragend. While the first mouseup was still processing a drag-drop at EventSender::FinishDragAndDrop, the second mouseup triggered another call to EventSender::FinishDragAndDrop, causing a premature call to WebViewImpl::dragTargetDragEnterOrOver with the crash. See the bug for a minimal test case. BUG=627340 Committed: https://crrev.com/f2d3dd78f333c287f6fcb44738bcf399b7af8515 Cr-Commit-Position: refs/heads/master@{#405510} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f2d3dd78f333c287f6fcb44738bcf399b7af8515 Cr-Commit-Position: refs/heads/master@{#405510} |
