Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 214873003: Don't log captive portal events in SSL interstitial if detection is disabled. (Closed)

Created:
6 years, 8 months ago by meacer
Modified:
6 years, 8 months ago
Reviewers:
cmp, mmenke, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Don't log captive portal events in SSL interstitial if detection is disabled. BUG=335933 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
meacer
Can you please review? Thanks.
6 years, 8 months ago (2014-03-27 17:56:27 UTC) #1
mmenke
LGTM
6 years, 8 months ago (2014-03-27 18:05:21 UTC) #2
Ryan Sleevi
lgtm
6 years, 8 months ago (2014-03-27 20:14:52 UTC) #3
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 8 months ago (2014-03-27 20:15:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/214873003/1
6 years, 8 months ago (2014-03-27 20:17:12 UTC) #5
meacer
The CQ bit was unchecked by meacer@chromium.org
6 years, 8 months ago (2014-03-28 22:11:11 UTC) #6
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 8 months ago (2014-03-28 22:11:12 UTC) #7
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 17:01:20 UTC) #8
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 17:05:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/214873003/1
6 years, 8 months ago (2014-03-30 17:05:39 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:28:44 UTC) #11
Message was sent while issue was closed.
Change committed as 260447

Powered by Google App Engine
This is Rietveld 408576698