Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214873002: Add UseCounter features for Document prefixed fullscreen APIs (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Add UseCounter features for Document prefixed fullscreen APIs Since the unprefixed API isn't event implemented yet removal is nowhere in sight, but it's still interesting to track these features over time. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170270

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M Source/core/dom/DocumentFullscreen.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-27 16:11:13 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-27 16:11:37 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-27 16:12:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/214873002/1
6 years, 9 months ago (2014-03-27 16:12:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:23:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 16:23:06 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-27 16:35:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/214873002/1
6 years, 9 months ago (2014-03-27 16:35:39 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:45:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 16:45:09 UTC) #10
sof
This ought to be caught by presubmit, but a rebase is needed here to have ...
6 years, 9 months ago (2014-03-27 19:53:49 UTC) #11
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-28 03:54:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/214873002/20001
6 years, 9 months ago (2014-03-28 03:54:30 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 04:19:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-28 04:19:20 UTC) #15
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-28 04:43:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/214873002/20001
6 years, 9 months ago (2014-03-28 04:44:03 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 05:08:57 UTC) #18
Message was sent while issue was closed. 
Change committed as 170270

Powered by Google App Engine
This is Rietveld 408576698