gpu/command_buffer/service/feature_info.cc - Issue 2148723004: WebGL 2: make sure VertexAttrib type match the corresponding attrib type in shader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2148723004: WebGL 2: make sure VertexAttrib type match the corresponding attrib type in shader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update vertex attrib base type for vertexAttrib{I}Pointer only if the vertex attrib array is enabled Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/context_state.h ('K') | « gpu/command_buffer/service/feature_info.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/feature_info.cc

diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc

index 19a8cb6bc411ee9afa9e881fea6d97ca63943dd3..7a566b3784e9f5d2c501c1b15b285c16fa7360a4 100644

--- a/gpu/command_buffer/service/feature_info.cc

+++ b/gpu/command_buffer/service/feature_info.cc

@@ -1417,6 +1417,14 @@ bool FeatureInfo::IsWebGLContext() const {

return false;

}

+bool FeatureInfo::IsWebGL2Context() const {

+ // Switch statement to cause a compile-time error if we miss a case.

Ken Russell (switch to Gerrit) 2016/07/21 00:16:21 This comment is wrong. Please use a switch stateme

yunchao 2016/07/22 13:43:53 Done.

+ if (context_type_ == CONTEXT_TYPE_WEBGL2) {

+ return true;

+ }

+ return false;

void FeatureInfo::AddExtensionString(const char* s) {

std::string str(s);

size_t pos = extensions_.find(str);