Improve ios/web/public/test/web_js_test.h

Improve ios/web/public/test/web_js_test.h

This CL does some minor changes to web_js_test.h based on eugenebut's
recommendations in https://codereview.chromium.org/2150513002/#msg21.

R=eugenebut@chromium.org
BUG=627775
Committed: https://crrev.com/2de879b6567bdd5383db462d0d3ee194bb4d998b
Cr-Commit-Position: refs/heads/master@{#405234}

[vabr (Chromium), 2016-07-13 18:13:02]

Hi Eugene,

PTAL, this addresses your first two comments from
https://codereview.chromium.org/2150513002/, I left the third unaddressed
following your https://codereview.chromium.org/2150513002/#msg23 (but if you
want me to add it, I'm happy to do so).

Cheers,
Vaclav

[vabr (Chromium), 2016-07-13 18:13:08]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 18:14:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-07-13 18:16:35]

lgtm, thanks for cleanup!

https://codereview.chromium.org/2148723003/diff/1/ios/web/public/test/web_js_...
File ios/web/public/test/web_js_test.h (right):

https://codereview.chromium.org/2148723003/diff/1/ios/web/public/test/web_js_...
ios/web/public/test/web_js_test.h:64:
DCHECK([WebTestT::EvaluateJavaScriptAsString(@"typeof __gCrWeb")
NIT:

DCHECK_NSEQ[@"object", WebTestT::ExecuteJavaScript(@"typeof __gCrWeb"));

[vabr (Chromium), 2016-07-13 18:51:26]

Thanks!

Comment addressed -> CQ.

Cheers,
Vaclav

https://codereview.chromium.org/2148723003/diff/1/ios/web/public/test/web_js_...
File ios/web/public/test/web_js_test.h (right):

https://codereview.chromium.org/2148723003/diff/1/ios/web/public/test/web_js_...
ios/web/public/test/web_js_test.h:64:
DCHECK([WebTestT::EvaluateJavaScriptAsString(@"typeof __gCrWeb")
On 2016/07/13 18:16:35, Eugene But wrote:
> NIT:
> 
> DCHECK_NSEQ[@"object", WebTestT::ExecuteJavaScript(@"typeof __gCrWeb"));

Done.

[vabr (Chromium), 2016-07-13 18:51:31]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-07-13 18:51:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2148723003/#ps20001
(title: "DCHECK_NSEQ")

[commit-bot: I haz the power, 2016-07-13 18:53:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:47:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 19:47:37]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 19:50:18]

Description was changed from

==========
Improve ios/web/public/test/web_js_test.h

This CL does some minor changes to web_js_test.h based on eugenebut's
recommendations in https://codereview.chromium.org/2150513002/#msg21.

R=eugenebut@chromium.org
BUG=627775
==========

to

==========
Improve ios/web/public/test/web_js_test.h

This CL does some minor changes to web_js_test.h based on eugenebut's
recommendations in https://codereview.chromium.org/2150513002/#msg21.

R=eugenebut@chromium.org
BUG=627775

Committed: https://crrev.com/2de879b6567bdd5383db462d0d3ee194bb4d998b
Cr-Commit-Position: refs/heads/master@{#405234}
==========

[commit-bot: I haz the power, 2016-07-13 19:50:21]

Patchset 2 (id:??) landed as
https://crrev.com/2de879b6567bdd5383db462d0d3ee194bb4d998b
Cr-Commit-Position: refs/heads/master@{#405234}

[vabr (Chromium), 2016-07-13 20:35:12]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2146793003/ by vabr@chromium.org.

The reason for reverting is: I'm afraid DCHECK_NSEQ is not defined, just EXPECT
and ASSERT. It seems to break compilation downstream. Let me revert and fix.

Vaclav.

[Eugene But (OOO till 7-30), 2016-07-13 20:40:29]

Sorry I actually meant EXPECT_NSEQ :(