Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2148703002: [ash-md] Fixes a bug with setting window shape to mask header in overview (Closed)

Created:
4 years, 5 months ago by varkha
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Fixes a bug with setting window shape to mask header in overview The bug was introduced in the last patch set of https://codereview.chromium.org/2129213003/. 1. Open an app window with insets (hidden header) and a few other windows. 2. Enter overview 3. While in overview close a few windows so that all windows grow. 4. Close overview by clicking the window with active shape (app frame). The first active window has its header and some client area content masked. BUG=624431 TBR=tdanderson@chromium.org Committed: https://crrev.com/625e4a99abe6a7f5021f53445b6db7428629f9f2 Cr-Commit-Position: refs/heads/master@{#405189}

Patch Set 1 : [ash-md] Fixes a bug with setting window shape to mask header in overview (rebased) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M ash/common/wm/overview/scoped_transform_overview_window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148703002/20001
4 years, 5 months ago (2016-07-13 16:36:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-13 16:41:39 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 16:41:40 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:44:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/625e4a99abe6a7f5021f53445b6db7428629f9f2
Cr-Commit-Position: refs/heads/master@{#405189}

Powered by Google App Engine
This is Rietveld 408576698