Parse the hash prefix map from the V4Store on disk.

components/safe_browsing_db/v4_store_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/time/time.h"
@@ skipping 121 matching lines @@
   std::unique_ptr<ListUpdateResponse> list_update_response(
       new ListUpdateResponse);
   list_update_response->set_response_type(ListUpdateResponse::FULL_UPDATE);
   list_update_response->set_new_client_state("test_client_state");
   EXPECT_EQ(WRITE_SUCCESS, V4Store(task_runner_, store_path_)
                                .WriteToDisk(std::move(list_update_response)));
 
   std::unique_ptr<V4Store> read_store(new V4Store(task_runner_, store_path_));
   EXPECT_EQ(READ_SUCCESS, read_store->ReadFromDisk());
   EXPECT_EQ("test_client_state", read_store->state_);
+  EXPECT_TRUE(read_store->hash_prefix_map_.empty());
 }
 
 TEST_F(V4StoreTest, TestAddUnlumpedHashesWithInvalidAddition) {
   HashPrefixMap prefix_map;
   EXPECT_EQ(ADDITIONS_SIZE_UNEXPECTED_FAILURE,
             V4Store::AddUnlumpedHashes(5, "a", &prefix_map));
   EXPECT_TRUE(prefix_map.empty());
 }
 
 TEST_F(V4StoreTest, TestAddUnlumpedHashesWithEmptyString) {
@@ skipping 178 matching lines @@
             V4Store::AddUnlumpedHashes(4, "2222", &prefix_map_old));
   HashPrefixMap prefix_map_additions;
   EXPECT_EQ(APPLY_UPDATE_SUCCESS,
             V4Store::AddUnlumpedHashes(4, "2222", &prefix_map_additions));
 
   std::unique_ptr<V4Store> store(new V4Store(task_runner_, store_path_));
   EXPECT_EQ(ADDITIONS_HAS_EXISTING_PREFIX_FAILURE,
             store->MergeUpdate(prefix_map_old, prefix_map_additions));
 }
 
+TEST_F(V4StoreTest, TestReadFullResponseWithValidHashPrefixMap) {
+  std::unique_ptr<ListUpdateResponse> lur(new ListUpdateResponse);
+  lur->set_response_type(ListUpdateResponse::FULL_UPDATE);
+  lur->set_new_client_state("test_client_state");
+  lur->set_platform_type(WINDOWS_PLATFORM);
+  lur->set_threat_entry_type(URL);
+  lur->set_threat_type(MALWARE_THREAT);
+  ThreatEntrySet* additions = lur->add_additions();
+  additions->set_compression_type(RAW);
+  additions->mutable_raw_hashes()->set_prefix_size(5);
+  additions->mutable_raw_hashes()->set_raw_hashes("00000abcde");
+  additions = lur->add_additions();
+  additions->set_compression_type(RAW);
+  additions->mutable_raw_hashes()->set_prefix_size(4);
+  additions->mutable_raw_hashes()->set_raw_hashes("00000abc");
+  EXPECT_EQ(WRITE_SUCCESS,
+            V4Store(task_runner_, store_path_).WriteToDisk(std::move(lur)));
+
+  std::unique_ptr<V4Store> read_store(new V4Store(task_runner_, store_path_));

[Nathan Parker, 2016/07/14 22:36:12]

could put this on the stack, rather than unique_ptr.

[vakh (use Gerrit instead), 2016/07/14 23:51:57]

Done.

+  EXPECT_EQ(READ_SUCCESS, read_store->ReadFromDisk());
+  EXPECT_EQ("test_client_state", read_store->state_);
+  EXPECT_EQ(2u, read_store->hash_prefix_map_.size());

[Nathan Parker, 2016/07/14 22:36:12]

nit: ASSERT_EQ since the later checks aren't useful and may segfault if the size
is wrong.

[vakh (use Gerrit instead), 2016/07/14 23:51:57]

Done.

+  EXPECT_EQ("00000abc", read_store->hash_prefix_map_[4]);
+  EXPECT_EQ("00000abcde", read_store->hash_prefix_map_[5]);
+}
+
+TEST_F(V4StoreTest, TestReadFullResponseInWithValidHashPrefixMap) {

[Nathan Parker, 2016/07/14 22:36:12]

What does the "In" in the name here mean, compared to the above function?

nit: Name is getting pretty long.  Maybe do s/HashPrefix//?

[vakh (use Gerrit instead), 2016/07/14 23:51:57]

Typo. Fixed.
I like it this way because:
- It uses the same terms in test and product code.
- If I change here, I won't be able to resist myself from changing it
consistently in the entire file, which isn't useful.
- If, at a later time, consistency causes other tests to become too long to fit
on a single line, I'll make the change.

+  std::unique_ptr<ListUpdateResponse> lur(new ListUpdateResponse);
+  lur->set_response_type(ListUpdateResponse::FULL_UPDATE);
+  lur->set_new_client_state("test_client_state");
+  lur->set_platform_type(WINDOWS_PLATFORM);
+  lur->set_threat_entry_type(URL);
+  lur->set_threat_type(MALWARE_THREAT);
+  ThreatEntrySet* additions = lur->add_additions();
+  additions->set_compression_type(RAW);
+  additions->mutable_raw_hashes()->set_prefix_size(5);
+  additions->mutable_raw_hashes()->set_raw_hashes("abcdef");
+  EXPECT_EQ(WRITE_SUCCESS,
+            V4Store(task_runner_, store_path_).WriteToDisk(std::move(lur)));
+
+  std::unique_ptr<V4Store> read_store(new V4Store(task_runner_, store_path_));
+  EXPECT_EQ(HASH_PREFIX_MAP_GENERATION_FAILURE, read_store->ReadFromDisk());

[Nathan Parker, 2016/07/14 22:36:12]

Add a comment above about what makes this fail.  I can't tell by reading it.

[vakh (use Gerrit instead), 2016/07/14 23:51:57]

Done.

+  EXPECT_TRUE(read_store->state_.empty());
+  EXPECT_TRUE(read_store->hash_prefix_map_.empty());
+}
+
 }  // namespace safe_browsing