[Presentation API] Adds DOMString[] constructor to PresentationRequest.

third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/presentation/PresentationAvailability.h"
 
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/Document.h"
 #include "core/events/Event.h"
 #include "core/frame/UseCounter.h"
 #include "modules/EventTargetModulesNames.h"
 #include "modules/presentation/PresentationController.h"
 #include "public/platform/Platform.h"
 #include "public/platform/modules/presentation/WebPresentationClient.h"
+#include "wtf/Vector.h"
 
 namespace blink {
 
 namespace {
 
 WebPresentationClient* presentationClient(ExecutionContext* executionContext)
 {
     ASSERT(executionContext && executionContext->isDocument());
 
     Document* document = toDocument(executionContext);
     if (!document->frame())
         return nullptr;
     PresentationController* controller = PresentationController::from(*document->frame());
     return controller ? controller->client() : nullptr;
 }
 
 } // anonymous namespace
 
 // static
-PresentationAvailability* PresentationAvailability::take(ScriptPromiseResolver* resolver, const KURL& url, bool value)
+PresentationAvailability* PresentationAvailability::take(ScriptPromiseResolver* resolver, const WTF::Vector<KURL>& urls, bool value)
 {
-    PresentationAvailability* presentationAvailability = new PresentationAvailability(resolver->getExecutionContext(), url, value);
+    PresentationAvailability* presentationAvailability = new PresentationAvailability(resolver->getExecutionContext(), urls, value);
     presentationAvailability->suspendIfNeeded();
     presentationAvailability->updateListening();
     return presentationAvailability;
 }
 
-PresentationAvailability::PresentationAvailability(ExecutionContext* executionContext, const KURL& url, bool value)
+PresentationAvailability::PresentationAvailability(ExecutionContext* executionContext, const WTF::Vector<KURL>& urls, bool value)
     : ActiveScriptWrappable(this)
     , ActiveDOMObject(executionContext)
     , PageVisibilityObserver(toDocument(executionContext)->page())
-    , m_url(url)
     , m_value(value)
     , m_state(State::Active)
 {
     ASSERT(executionContext->isDocument());
+    WebVector<WebURL> data(urls.size());
+    for (size_t i = 0; i < urls.size(); ++i) {
+        data[i] = WebURL(urls[i]);
+    }

[mlamouri (slow - plz ping), 2016/07/19 12:45:03]

style: we don't use { } when not needed usually.

[mark a. foltz, 2016/07/19 17:38:47]

Done.

+    m_urls.swap(data);

[mlamouri (slow - plz ping), 2016/07/19 12:45:03]

nit: I am probably missing something but could you use `m_urls` instead of
`data` above?

[mark a. foltz, 2016/07/19 17:38:47]

WebVector does not provide any method to resize itself once allocated.  To
populate the vector, the sample code suggests using swap().  See:

https://cs-staging.chromium.org/chromium/src/third_party/WebKit/public/platfo...

[mlamouri (slow - plz ping), 2016/07/20 13:02:10]

I'm speechless :)

[imcheng, 2016/07/20 17:20:45]

But you can initialize m_urls with a size param, right?

 }
 
 PresentationAvailability::~PresentationAvailability()
 {
 }
 
 const AtomicString& PresentationAvailability::interfaceName() const
 {
     return EventTargetNames::PresentationAvailability;
 }
@@ skipping 57 matching lines @@
     WebPresentationClient* client = presentationClient(getExecutionContext());
     if (!client)
         return;
 
     if (m_state == State::Active && (toDocument(getExecutionContext())->pageVisibilityState() == PageVisibilityStateVisible))
         client->startListening(this);
     else
         client->stopListening(this);
 }
 
-const WebURL PresentationAvailability::url() const
+const WebVector<WebURL>& PresentationAvailability::urls() const
 {
-    return WebURL(m_url);
+    return m_urls;
 }
 
 bool PresentationAvailability::value() const
 {
     return m_value;
 }
 
 DEFINE_TRACE(PresentationAvailability)
 {
     EventTargetWithInlineData::trace(visitor);
     PageVisibilityObserver::trace(visitor);
     ActiveDOMObject::trace(visitor);
 }
 
 } // namespace blink