Extension API enterprise.platformKeys.

chrome/renderer/resources/extensions/enterprise_platform_keys_internal_custom_bindings.js

Index: chrome/renderer/resources/extensions/enterprise_platform_keys_internal_custom_bindings.js
diff --git a/chrome/test/data/extensions/api_test/automation/tests/content.js b/chrome/renderer/resources/extensions/enterprise_platform_keys_internal_custom_bindings.js
similarity index 53%
copy from chrome/test/data/extensions/api_test/automation/tests/content.js
copy to chrome/renderer/resources/extensions/enterprise_platform_keys_internal_custom_bindings.js
index 694ce16d00f475777f11980ad6ac9198bff4ef43..25120f3f62d267b100f1c0c3c92ed35a5823b491 100644
--- a/chrome/test/data/extensions/api_test/automation/tests/content.js
+++ b/chrome/renderer/resources/extensions/enterprise_platform_keys_internal_custom_bindings.js
@@ -2,4 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-chrome.runtime.sendMessage({ 'loaded': true });
+exports.binding = require('binding')
+                      .Binding.create('enterprise.platformKeysInternal')
+                      .generate();

[not at google - send to devlin, 2014/05/05 21:09:24]

this simple behaviour is generated for you. you only need the separate
custom_bindings file if you do the registerCustomHook stuff.

[pneubeck (no reviews), 2014/05/06 14:07:21]

Hm, would be nice, but if I only remove the according
source_map_.RegisterSource, I get the error
  (BLESSED_EXTENSION context for kmdkjjdaihhnmbakbnbmljnmfcgelkcg) No source for
require(enterprise.platformKeysInternal)

Which I think is expected because the internal API is marked
  "internal": true
in _api_features.json

[not at google - send to devlin, 2014/05/07 00:00:12]

Ah right.

Yes, the problem is that you're accessing chrome.platformKeysInternal and
expecting that to be generated.

Internal APIs need to be expilicitly require(..)'d, like

var platformKeysInternal = require('platformKeysInternal')

they never get entries on the chrome object, otherwise extensions can access
them.

[pneubeck (no reviews), 2014/05/07 21:44:19]

Internal APIs are accessed by e.g.:
var binding = require('binding').Binding.create('webRequestInternal');

(see
https://code.google.com/p/chromium/codesearch#search/&q=require%5C(.*internal...
)

the code which prevents the creation of the binding is here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/renderer/ex...

I didn't want to generate the binding more than once, thus I put it into a
separate module.

[not at google - send to devlin, 2014/05/08 00:13:14]

I see. Don't call it "custom bindings" though, it's confusing since it's not
actually a custom binding. That means a very specific thing. Perhaps an
"internal_api.js" file inside the enterprise_platform_keys directory. Loop over
the public interface to set on exports too; the 'binding' thing is also
confusing.

[pneubeck (no reviews), 2014/05/08 15:04:17]

Yes, that's better.
Done.