Extension API enterprise.platformKeys.

chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.h

Index: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.h
diff --git a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.h b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.h
new file mode 100644
index 0000000000000000000000000000000000000000..5556505ab93c76bf4eab0699195645a75744a54e
--- /dev/null
+++ b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.h
@@ -0,0 +1,123 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_PLATFORM_KEYS_ENTERPRISE_PLATFORM_KEYS_API_H_
+#define CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_PLATFORM_KEYS_ENTERPRISE_PLATFORM_KEYS_API_H_
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/extensions/chrome_extension_function.h"
+
+namespace extensions {
+
+namespace enterprise_platform_keys {

[not at google - send to devlin, 2014/05/05 21:09:24]

this inner namespace is unusual. see comment below, typically you will namespace
via long function names, in order for the generated code to pick this up.

[pneubeck (no reviews), 2014/05/05 21:28:23]

See typedefs at the end. TheNamesAreReallyExtreeeemelyLoooooooong....

[not at google - send to devlin, 2014/05/05 21:44:49]

I see. Yeah, I dunno, I was confused, so chances are other people will be too.
The idiomatic thing is to not worry about this namespace + typedef thing, it's
quite unusual. "git cl format" handles long lines just fine.

[pneubeck (no reviews), 2014/05/06 14:07:21]

Long names are problematic because you have too read them and they're hiding the
important information.
Thus, I still disagree with 'namespacing by prefixes'. Luckily we're in C++ with
that nice feature called namespaces... ;-)

I added a comment at the top to hopefully prevent any future confusion.

[not at google - send to devlin, 2014/05/07 00:00:12]

Ok if you insist. This is just very unusual. No other function does it and it
looks weird to me.

[not at google - send to devlin, 2014/05/07 15:42:25]

I had a realisation last night that we should be generating these function names
into the right namespace. Should have been doing so all along, unfortunately.

I.e. you're on to something here.

This could be a change to make to the schema compiler, like, add an annotation
"sane_function_names" which instead of generating
"EnterprisePlatformKeysInternalGenerateKeyFunction" could generate
"extensions::api::enterprise_platform_keys_internal::GenerateKeyFunction". A
further nice property of that is that everybody wouldn't need to have those
namespace aliases in their CC files.

+
+class TokenMethodExtensionFunction : public ChromeAsyncExtensionFunction {

[not at google - send to devlin, 2014/05/05 21:09:24]

I just submitted r268033 which encourages you to implement
ChromeUIThreadExtensionFunction instead of ChromeAsyncExtensionFunction. You
override Run() not RunImpl() and have understandable return values. It would be
nice to start using it here, but given you've already done the work, not a big
deal if you don't.

it's well commented at ExtensionFunction::Run.

[pneubeck (no reviews), 2014/05/06 14:07:21]

Done.

+ public:
+  void SetResults(scoped_ptr<base::ListValue> results);
+  virtual void SendResponse(bool success) OVERRIDE;
+
+ protected:
+  TokenMethodExtensionFunction();
+  virtual ~TokenMethodExtensionFunction();
+
+  bool ValidateToken(const std::string& token_id);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TokenMethodExtensionFunction);
+};
+
+class Generate : public TokenMethodExtensionFunction {

[not at google - send to devlin, 2014/05/05 21:09:24]

registration for these functions is generated by the schema compiler. you should
call them things like EnterprisePlatformKeysInternalGenerateKeyFunction (the
auto-generated name, I think).

[pneubeck (no reviews), 2014/05/06 14:07:21]

Done.

+ public:
+  Generate();
+
+ protected:
+  virtual ~Generate();
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  DECLARE_EXTENSION_FUNCTION("enterprise.platformKeysInternal.generateKey",
+                             ENTERPRISE_PLATFORMKEYSINTERNAL_GENERATEKEY);
+};
+
+class Sign : public TokenMethodExtensionFunction {
+ public:
+  Sign();
+
+ protected:
+  virtual ~Sign();
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  DECLARE_EXTENSION_FUNCTION("enterprise.platformKeysInternal.sign",
+                             ENTERPRISE_PLATFORMKEYSINTERNAL_SIGN);
+};
+
+class GetCerts : public TokenMethodExtensionFunction {
+ public:
+  GetCerts();
+
+ protected:
+  virtual ~GetCerts();
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  DECLARE_EXTENSION_FUNCTION("enterprise.platformKeys.getCertificates",
+                             ENTERPRISE_PLATFORMKEYS_GETCERTIFICATES);
+};
+
+class ImportCert : public TokenMethodExtensionFunction {
+ public:
+  ImportCert();
+
+ protected:
+  virtual ~ImportCert();
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  DECLARE_EXTENSION_FUNCTION("enterprise.platformKeys.importCertificate",
+                             ENTERPRISE_PLATFORMKEYS_IMPORTCERTIFICATE);
+};
+
+class RemoveCert : public TokenMethodExtensionFunction {
+ public:
+  RemoveCert();
+
+ protected:
+  virtual ~RemoveCert();
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  DECLARE_EXTENSION_FUNCTION("enterprise.platformKeys.removeCertificate",
+                             ENTERPRISE_PLATFORMKEYS_REMOVECERTIFICATE);
+};
+
+class GetTokens : public ChromeAsyncExtensionFunction {
+ protected:
+  virtual ~GetTokens();
+  virtual bool RunImpl() OVERRIDE;
+
+ private:
+  DECLARE_EXTENSION_FUNCTION("enterprise.platformKeysInternal.getTokens",
+                             ENTERPRISE_PLATFORMKEYSINTERNAL_GETTOKENS);
+};
+
+}  // namespace enterprise_platform_keys
+
+typedef enterprise_platform_keys::Generate
+    EnterprisePlatformKeysInternalGenerateKeyFunction;
+typedef enterprise_platform_keys::Sign
+    EnterprisePlatformKeysInternalSignFunction;
+typedef enterprise_platform_keys::GetTokens
+    EnterprisePlatformKeysInternalGetTokensFunction;
+
+typedef enterprise_platform_keys::GetCerts
+    EnterprisePlatformKeysGetCertificatesFunction;
+typedef enterprise_platform_keys::ImportCert
+    EnterprisePlatformKeysImportCertificateFunction;
+typedef enterprise_platform_keys::RemoveCert
+    EnterprisePlatformKeysRemoveCertificateFunction;
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_PLATFORM_KEYS_ENTERPRISE_PLATFORM_KEYS_API_H_