runtime/vm/isolate.cc - Issue 2148613002: Have --print-metrics use stderr to work around issue with analyzer_cli

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 2148613002: Have --print-metrics use stderr to work around issue with analyzer_cli (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Have --print-metrics use stderr to work around issue with analyzer_cli Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc

index 5dc9a9f6b4807f08f4723738baa3015ba23522fe..295a8d606d9ec0490fc81e9e9f1d46b1105b0022 100644

--- a/runtime/vm/isolate.cc

+++ b/runtime/vm/isolate.cc

@@ -1630,13 +1630,13 @@ void Isolate::LowLevelShutdown() {

}

if (FLAG_print_metrics) {

LogBlock lb;

- THR_Print("Printing metrics for %s\n", name());

+ fprintf(stderr, "Printing metrics for %s\n", name());

rmacnak 2016/07/13 00:21:48 OS::PrintErr so it goes to syslog on Android and i

Cutch 2016/07/13 15:52:55 Done.

#define ISOLATE_METRIC_PRINT(type, variable, name, unit) \

- THR_Print("%s\n", metric_##variable##_.ToString());

+ fprintf(stderr, "%s\n", metric_##variable##_.ToString());

ISOLATE_METRIC_LIST(ISOLATE_METRIC_PRINT);

#undef ISOLATE_METRIC_PRINT

- THR_Print("\n");

+ fprintf(stderr, "\n");

}

« no previous file with comments | « no previous file | runtime/vm/metrics.cc » ('j') | no next file with comments »