runtime/vm/metrics.cc - Issue 2148613002: Have --print-metrics use stderr to work around issue with analyzer_cli

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/metrics.cc

Issue 2148613002: Have --print-metrics use stderr to work around issue with analyzer_cli (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/metrics.cc

diff --git a/runtime/vm/metrics.cc b/runtime/vm/metrics.cc

index cb6c2055217070efbcbff0918f9844cdfd9cf109..f3e16c5bac8c0901f032361352d82467fbf9ae75 100644

--- a/runtime/vm/metrics.cc

+++ b/runtime/vm/metrics.cc

@@ -306,10 +306,10 @@ void Metric::Cleanup() {

if (FLAG_print_metrics) {

// Create a zone to allocate temporary strings in.

StackZone sz(Thread::Current());

- OS::Print("Printing metrics for VM\n");

+ fprintf(stderr, "Printing metrics for VM\n");

Metric* current = Metric::vm_head();

while (current != NULL) {

- OS::Print("%s\n", current->ToString());

+ fprintf(stdout, "%s\n", current->ToString());

Harry Terkelsen 2016/07/13 00:16:28 stderr here

Cutch 2016/07/13 00:17:43 Done.

current = current->next();

}

OS::Print("\n");

« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »