Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2148613002: Have --print-metrics use stderr to work around issue with analyzer_cli (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Have --print-metrics use stderr to work around issue with analyzer_cli BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2cb555c7dd9ce0d39e331cb9739b520c86d7cb74

Patch Set 1 #

Total comments: 2

Patch Set 2 : Have --print-metrics use stderr to work around issue with analyzer_cli #

Total comments: 2

Patch Set 3 : rmacnak review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M runtime/vm/isolate.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/metrics.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Cutch
4 years, 5 months ago (2016-07-13 00:15:04 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/2148613002/diff/1/runtime/vm/metrics.cc File runtime/vm/metrics.cc (right): https://codereview.chromium.org/2148613002/diff/1/runtime/vm/metrics.cc#newcode312 runtime/vm/metrics.cc:312: fprintf(stdout, "%s\n", current->ToString()); stderr here
4 years, 5 months ago (2016-07-13 00:16:28 UTC) #5
Cutch
https://codereview.chromium.org/2148613002/diff/1/runtime/vm/metrics.cc File runtime/vm/metrics.cc (right): https://codereview.chromium.org/2148613002/diff/1/runtime/vm/metrics.cc#newcode312 runtime/vm/metrics.cc:312: fprintf(stdout, "%s\n", current->ToString()); On 2016/07/13 00:16:28, Harry Terkelsen wrote: ...
4 years, 5 months ago (2016-07-13 00:17:43 UTC) #6
rmacnak
lgtm w/c https://codereview.chromium.org/2148613002/diff/20001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): https://codereview.chromium.org/2148613002/diff/20001/runtime/vm/isolate.cc#newcode1633 runtime/vm/isolate.cc:1633: fprintf(stderr, "Printing metrics for %s\n", name()); OS::PrintErr ...
4 years, 5 months ago (2016-07-13 00:21:48 UTC) #7
Cutch
https://codereview.chromium.org/2148613002/diff/20001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): https://codereview.chromium.org/2148613002/diff/20001/runtime/vm/isolate.cc#newcode1633 runtime/vm/isolate.cc:1633: fprintf(stderr, "Printing metrics for %s\n", name()); On 2016/07/13 00:21:48, ...
4 years, 5 months ago (2016-07-13 15:52:56 UTC) #9
Cutch
4 years, 5 months ago (2016-07-13 15:52:57 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
2cb555c7dd9ce0d39e331cb9739b520c86d7cb74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698