Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Side by Side Diff: tools/gn/target_generator.cc

Issue 2148593002: [GN Docs] Fix typo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/target_generator.h" 5 #include "tools/gn/target_generator.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "tools/gn/action_target_generator.h" 9 #include "tools/gn/action_target_generator.h"
10 #include "tools/gn/binary_target_generator.h" 10 #include "tools/gn/binary_target_generator.h"
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 298
299 SubstitutionList& outputs = target_->action_values().outputs(); 299 SubstitutionList& outputs = target_->action_values().outputs();
300 if (!outputs.Parse(*value, err_)) 300 if (!outputs.Parse(*value, err_))
301 return false; 301 return false;
302 302
303 if (!allow_substitutions) { 303 if (!allow_substitutions) {
304 // Verify no substitutions were actually used. 304 // Verify no substitutions were actually used.
305 if (!outputs.required_types().empty()) { 305 if (!outputs.required_types().empty()) {
306 *err_ = Err(*value, "Source expansions not allowed here.", 306 *err_ = Err(*value, "Source expansions not allowed here.",
307 "The outputs of this target used source {{expansions}} but this " 307 "The outputs of this target used source {{expansions}} but this "
308 "targe type\ndoesn't support them. Just express the outputs " 308 "target type\ndoesn't support them. Just express the outputs "
309 "literally."); 309 "literally.");
310 return false; 310 return false;
311 } 311 }
312 } 312 }
313 313
314 // Check the substitutions used are valid for this purpose. 314 // Check the substitutions used are valid for this purpose.
315 if (!EnsureValidSourcesSubstitutions(outputs.required_types(), 315 if (!EnsureValidSourcesSubstitutions(outputs.required_types(),
316 value->origin(), err_)) 316 value->origin(), err_))
317 return false; 317 return false;
318 318
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 if (err_->has_error()) 398 if (err_->has_error())
399 return false; 399 return false;
400 if (!EnsureStringIsInOutputDir(GetBuildSettings()->build_dir(), 400 if (!EnsureStringIsInOutputDir(GetBuildSettings()->build_dir(),
401 source_file.value(), value->origin(), err_)) 401 source_file.value(), value->origin(), err_))
402 return false; 402 return false;
403 OutputFile output_file(GetBuildSettings(), source_file); 403 OutputFile output_file(GetBuildSettings(), source_file);
404 target_->set_write_runtime_deps_output(output_file); 404 target_->set_write_runtime_deps_output(output_file);
405 405
406 return true; 406 return true;
407 } 407 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698