Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2148583003: Minor cleanups in media/s BUILD.gns and media/capture files (Closed)

Created:
4 years, 5 months ago by mcasas
Modified:
4 years, 5 months ago
Reviewers:
Avi (use Gerrit), hubbe
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, piman+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor cleanups in media/s BUILD.gns and media/capture files This CL: - removes some unnecessary dependencies, following up on a TODO - removes unnecessary include and MEDIA_EXPORT in recently landed code - correct photo_capabilities.h header guard BUG=626125, 618718 TEST=No new coded added, if it compiles, is good. Committed: https://crrev.com/14a3cda4337f498d01ccbf897884f343ee099805 Cr-Commit-Position: refs/heads/master@{#405553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M media/capture/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M media/capture/content/android/screen_capture_jni_registrar.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/capture/content/android/screen_capture_machine_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/capture/video/android/photo_capabilities.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
mcasas
hubbe@ PTAL
4 years, 5 months ago (2016-07-14 15:53:47 UTC) #11
hubbe
lgtm
4 years, 5 months ago (2016-07-14 17:20:31 UTC) #12
mcasas
avi@ RS one-line diff in content/browser/BUILD.gn Cheers!
4 years, 5 months ago (2016-07-14 17:21:52 UTC) #14
Avi (use Gerrit)
lgtm
4 years, 5 months ago (2016-07-14 18:00:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148583003/60001
4 years, 5 months ago (2016-07-14 18:16:31 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 5 months ago (2016-07-14 20:13:22 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 20:17:34 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14a3cda4337f498d01ccbf897884f343ee099805
Cr-Commit-Position: refs/heads/master@{#405553}

Powered by Google App Engine
This is Rietveld 408576698