Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2148583002: Revert "[DevTools] Allow modifying instrumenting agents while iterating." (Closed)

Created:
4 years, 5 months ago by jam
Modified:
4 years, 5 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[DevTools] Allow modifying instrumenting agents while iterating." This reverts commit a0206e7e8481b0bd171beb9fc895bd55201eff6e. BUG=627373 R=stip@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2a36df6e42a3b6a81e1f391b46894b95a17daa08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -105 lines) Patch
D third_party/WebKit/LayoutTests/inspector-protocol/debugger/detach-when-paused-in-instrumentation.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/debugger/detach-when-paused-in-instrumentation-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 4 chunks +3 lines, -69 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jam
4 years, 5 months ago (2016-07-12 23:00:58 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2a36df6e42a3b6a81e1f391b46894b95a17daa08 Cr-Commit-Position: refs/heads/master@{#404854}
4 years, 5 months ago (2016-07-12 23:06:56 UTC) #3
jam
4 years, 5 months ago (2016-07-12 23:08:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2a36df6e42a3b6a81e1f391b46894b95a17daa08.

Powered by Google App Engine
This is Rietveld 408576698