MD Settings: Bluetooth: Additional polish

MD Settings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b
Cr-Commit-Position: refs/heads/master@{#405921}

[stevenjb, 2016-07-12 23:07:01]

Description was changed from

==========
MD Setttings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Setttings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-07-12 23:13:29]

Description was changed from

==========
MD Setttings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Setttings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-07-12 23:14:51]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-07-13 02:21:46]

looks pretty good to me!

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:107:
type="text" auto-validate value="{{pinorpass}}">
pinOrPass

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
(right):

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:209:
return value != undefined && value != '' && paperInput.validate();
return !!value && paperInput.validate();

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:292:
pairing == PairingEventType.CONFIRM_PASSKEY)) {
is clang format doing these things?

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
(right):

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html:56:
on-change="onBluetoothEnabledChange_" actionable>
i think we should make all paper-toggle-buttons actionable by default in
settings-shared or in polymer itself.  happy to keep this part of your change
for now as long as you remember to remove it later ;)

[stevenjb, 2016-07-13 17:12:24]

ptal

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:107:
type="text" auto-validate value="{{pinorpass}}">
On 2016/07/13 02:21:45, Dan Beam wrote:
> pinOrPass

Done.

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
(right):

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:209:
return value != undefined && value != '' && paperInput.validate();
On 2016/07/13 02:21:45, Dan Beam wrote:
> return !!value && paperInput.validate();

That's not quite the same, e.g. if value were 0, but I guess that couldn't
happen here since paperInput.value is a String... done.

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:292:
pairing == PairingEventType.CONFIRM_PASSKEY)) {
On 2016/07/13 02:21:45, Dan Beam wrote:
> is clang format doing these things?

Yes.

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
(right):

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html:56:
on-change="onBluetoothEnabledChange_" actionable>
On 2016/07/13 02:21:46, Dan Beam wrote:
> i think we should make all paper-toggle-buttons actionable by default in
> settings-shared or in polymer itself.  happy to keep this part of your change
> for now as long as you remember to remove it later ;)

Will do that separately, removed change from here.

[Dan Beam, 2016-07-16 00:29:39]

Description was changed from

==========
MD Setttings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-16 00:32:07]

Description was changed from

==========
MD Settings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-16 00:35:11]

lgtm

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
(right):

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:209:
return value != undefined && value != '' && paperInput.validate();
On 2016/07/13 17:12:24, stevenjb wrote:
> On 2016/07/13 02:21:45, Dan Beam wrote:
> > return !!value && paperInput.validate();
> 
> That's not quite the same, e.g. if value were 0, but I guess that couldn't
> happen here since paperInput.value is a String... done.

0 == ''

mind == blown

https://codereview.chromium.org/2148573003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(left):

https://codereview.chromium.org/2148573003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:100:
<div id="pairing" class="settings-blox layout vertical center
damn you, settings-bloxxxxxxxxxxx!

https://codereview.chromium.org/2148573003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js (right):

https://codereview.chromium.org/2148573003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js:302:
'startDsicovery Error: ' + chrome.runtime.lastError.message);
startDiscovery

[stevenjb, 2016-07-16 01:06:52]

Description was changed from

==========
MD Settings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-07-16 01:07:03]

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
(right):

https://codereview.chromium.org/2148573003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:209:
return value != undefined && value != '' && paperInput.validate();
On 2016/07/16 00:35:11, Dan Beam wrote:
> On 2016/07/13 17:12:24, stevenjb wrote:
> > On 2016/07/13 02:21:45, Dan Beam wrote:
> > > return !!value && paperInput.validate();
> > 
> > That's not quite the same, e.g. if value were 0, but I guess that couldn't
> > happen here since paperInput.value is a String... done.
> 
> 0 == ''
> 
> mind == blown

Yeah, that should have been "value !== ''". I frickin hate Javascript.

https://codereview.chromium.org/2148573003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(left):

https://codereview.chromium.org/2148573003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:100:
<div id="pairing" class="settings-blox layout vertical center
On 2016/07/16 00:35:11, Dan Beam wrote:
> damn you, settings-bloxxxxxxxxxxx!

:)

https://codereview.chromium.org/2148573003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js (right):

https://codereview.chromium.org/2148573003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js:302:
'startDsicovery Error: ' + chrome.runtime.lastError.message);
On 2016/07/16 00:35:11, Dan Beam wrote:
> startDiscovery

Done.

[stevenjb, 2016-07-16 01:07:07]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-07-16 01:07:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2148573003/#ps60001
(title: "Spelling")

[commit-bot: I haz the power, 2016-07-16 01:07:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 01:07:31]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-16 02:10:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-16 02:12:27]

Description was changed from

==========
MD Settings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Bluetooth: Additional polish

This CL:
* Does some code cleanup
* Fixes showing and enabling of the Connect button
* Fixes pincode and passkey logic
* Disables the 'enable' UI when bluetooth is not available.

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b
Cr-Commit-Position: refs/heads/master@{#405921}
==========

[commit-bot: I haz the power, 2016-07-16 02:12:28]

Patchset 4 (id:??) landed as
https://crrev.com/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b
Cr-Commit-Position: refs/heads/master@{#405921}