Add palette tray to ash.

Add palette tray to ash.

Design doc: go/caebn

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
Committed: https://crrev.com/b9918821e0303c84ef56af1d753345b819b0a25c
Cr-Commit-Position: refs/heads/master@{#407654}

[jdufault, 2016-07-12 23:59:04]

Description was changed from

==========
Add palette tray to ash.

BUG=625251
==========

to

==========
Add palette tray to ash.

This is dependent on a number of CLs:

- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
==========

[jdufault, 2016-07-12 23:59:15]

Description was changed from

==========
Add palette tray to ash.

This is dependent on a number of CLs:

- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
==========

to

==========
Add palette tray to ash.

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
==========

[jdufault, 2016-07-13 00:00:08]

Description was changed from

==========
Add palette tray to ash.

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
==========

to

==========
Add palette tray to ash.

Design doc: go/caebn

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
==========

[jdufault, 2016-07-13 19:32:11]

jdufault@chromium.org changed reviewers:
+ oshima@chromium.org, tdanderson@chromium.org

[jdufault, 2016-07-13 19:32:31]

Oshima, PTAL. Thanks!

+tdanderson@ for FYI.

[jdufault, 2016-07-13 19:32:58]

Patchset #1 (id:1) has been deleted

[oshima, 2016-07-13 21:14:23]

can you take a look at build failures?

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:171: views::View* anchor =
this->tray_container();
try_container()?

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:172: DCHECK(anchor);
or just inline tray_container()

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:196: return;
can you add comment?

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:290:
kHorizontalShelfVerticalPadding, kHorizontalShelfHorizontalPadding,
nit: Insets(h, v) may be shorter.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:309: return;
debug code?

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.h (right):

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:34: // ActionableView
overrides.
nit:  // ActionableView:

same for the rest.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:48: // friend class
OverviewButtonTrayTest;
remove this?

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:78:
std::unique_ptr<TrayBubbleWrapper> bubble_;
#include <memory>

[jdufault, 2016-07-18 20:43:44]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[jdufault, 2016-07-18 20:44:02]

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:171: views::View* anchor =
this->tray_container();
On 2016/07/13 21:14:23, oshima wrote:
> try_container()? 

Done.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:172: DCHECK(anchor);
On 2016/07/13 21:14:23, oshima wrote:
> or just inline tray_container()

Done.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:196: return;
On 2016/07/13 21:14:23, oshima wrote:
> can you add comment? 

Done.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:290:
kHorizontalShelfVerticalPadding, kHorizontalShelfHorizontalPadding,
On 2016/07/13 21:14:23, oshima wrote:
> nit: Insets(h, v) may be shorter.

Easier to read, at least.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:309: return;
On 2016/07/13 21:14:23, oshima wrote:
> debug code?

There's no command line flag added yet that this will check. I've pulled this
out into a separate function so we're closer to the final logic.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.h (right):

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:34: // ActionableView
overrides.
On 2016/07/13 21:14:23, oshima wrote:
> nit:  // ActionableView:
> 
> same for the rest.

Done.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:48: // friend class
OverviewButtonTrayTest;
On 2016/07/13 21:14:23, oshima wrote:
> remove this?

Done.

https://codereview.chromium.org/2148573002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:78:
std::unique_ptr<TrayBubbleWrapper> bubble_;
On 2016/07/13 21:14:23, oshima wrote:
> #include <memory>

Done.

[commit-bot: I haz the power, 2016-07-18 20:44:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 20:48:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 20:48:13]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oshima, 2016-07-18 23:43:19]

lgtm

https://codereview.chromium.org/2148573002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:309:
icon_->SetImage(image_md);
nit: just inline?

[tdanderson, 2016-07-19 13:55:41]

https://chromiumcodereview.appspot.com/2148573002/diff/60001/ash/common/syste...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://chromiumcodereview.appspot.com/2148573002/diff/60001/ash/common/syste...
ash/common/system/chromeos/palette/palette_tray.cc:294: void
PaletteTray::SetIconBorderForShelfAlignment() {
When this CL is ready to land, can you please file a bug (assign it to me) and
add a TODO(tdanderson): Ensure PaletteTray follows material design specs. See
crbug.com/xxx.

[jdufault, 2016-07-21 23:45:43]

Oshima, PTAL again. There have been some changes to account for changes in the
parent CL.

https://codereview.chromium.org/2148573002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:294: void
PaletteTray::SetIconBorderForShelfAlignment() {
On 2016/07/19 13:55:41, tdanderson wrote:
> When this CL is ready to land, can you please file a bug (assign it to me) and
> add a TODO(tdanderson): Ensure PaletteTray follows material design specs. See
> crbug.com/xxx. 

Done.

https://codereview.chromium.org/2148573002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:309:
icon_->SetImage(image_md);
On 2016/07/18 23:43:19, oshima wrote:
> nit: just inline?

Done.

[jdufault, 2016-07-21 23:46:22]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 23:47:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 01:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:47:04]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-07-22 19:35:43]

lgtm

[jdufault, 2016-07-22 22:33:05]

jdufault@chromium.org changed reviewers:
+ estade@chromium.org

[jdufault, 2016-07-22 22:33:29]

+estade@ for icons

[Evan Stade, 2016-07-22 23:04:34]

I don't think this is the right CL to have added the .icons to because I don't
see any references to most of them.

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:38: // border of the icon,
depending on the current shelf_alignment()
nit: final punctuation and vertical bars around code references.

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:113: }  // namespace
I would put this anonymous namespace inside the ash namespace

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:304:
base::Optional<gfx::VectorIconId> tray_icon =
I don't think base::Optional is necessary here, typically we return
gfx::VectorIconId::VECTOR_ICON_NONE for a non-value. Since PaletteToolManager is
in some other CL and I don't want to go hunting for it, I'll just ask: why
doesn't PaletteToolManager::GetActiveTrayIcon incorporate the fallback icon
logic?

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.h (right):

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.h:28: class ASH_EXPORT
PaletteTray : public TrayBackgroundView,
could you add some class level docs here por favor?

[jdufault, 2016-07-25 19:28:29]

> I don't think this is the right CL to have added the .icons 
> to because I don't see any references to most of them.

I've pulled the icons into the CLs that reference them.

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:38: // border of the icon,
depending on the current shelf_alignment()
On 2016/07/22 23:04:34, Evan Stade wrote:
> nit: final punctuation and vertical bars around code references.

Done.

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:113: }  // namespace
On 2016/07/22 23:04:34, Evan Stade wrote:
> I would put this anonymous namespace inside the ash namespace

Done.

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:304:
base::Optional<gfx::VectorIconId> tray_icon =
On 2016/07/22 23:04:34, Evan Stade wrote:
> I don't think base::Optional is necessary here, typically we return
> gfx::VectorIconId::VECTOR_ICON_NONE for a non-value. Since PaletteToolManager
is
> in some other CL and I don't want to go hunting for it, I'll just ask: why
> doesn't PaletteToolManager::GetActiveTrayIcon incorporate the fallback icon
> logic?

I've removed the base::Optional bit.

The fallback logic resides here because PaletteToolManager isn't responsible for
any view computations. It's essentially just a lifetime manager.

View logic is either in this class, or the actual tools. In a previous CL, all
of the tray icons were in this file, but I decided to move the icons to the
tools so that all of the tool-specific data stayed in one place.

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.h (right):

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.h:28: class ASH_EXPORT
PaletteTray : public TrayBackgroundView,
On 2016/07/22 23:04:34, Evan Stade wrote:
> could you add some class level docs here por favor?

Done.

[Evan Stade, 2016-07-25 19:57:54]

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:304:
base::Optional<gfx::VectorIconId> tray_icon =
On 2016/07/25 19:28:29, jdufault wrote:
> On 2016/07/22 23:04:34, Evan Stade wrote:
> > I don't think base::Optional is necessary here, typically we return
> > gfx::VectorIconId::VECTOR_ICON_NONE for a non-value. Since
PaletteToolManager
> is
> > in some other CL and I don't want to go hunting for it, I'll just ask: why
> > doesn't PaletteToolManager::GetActiveTrayIcon incorporate the fallback icon
> > logic?
> 
> I've removed the base::Optional bit.
> 
> The fallback logic resides here because PaletteToolManager isn't responsible
for
> any view computations. It's essentially just a lifetime manager.
> 
> View logic is either in this class, or the actual tools. In a previous CL, all
> of the tray icons were in this file, but I decided to move the icons to the
> tools so that all of the tool-specific data stayed in one place.

sorry, still don't follow. I tracked down where this was being added. Why is it
not

PaletteTool::GetActiveTrayIcon() {
  return gfx::VectorIconId::PALETTE_TRAY_ICON_DEFAULT;
}

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:46: // Width of the palette
itself.
nit: specify unit (dp)

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:69: class TitleBarView :
public views::View {
doesn't seem like you need a new class for this? Can just create a View and do
all this stuff.

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:81: 0,
ash::kTrayPopupPaddingHorizontal, 0, 0));
I would put this on the whole TitleBarView. I'm surprised you only want it on
one side though, given the name (PaddingHorizontal rather than Indent or
something).

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:167:
bubble_view->set_margins(gfx::Insets(kBubbleViewTopMargin, 0, 0, 0));
does this not square off the bottom corners of the bubble? Perhaps not if the bg
is transparent.

I think it would be slightly cleaner to set the margins to empty and cook
kBubbleViewTopMargin into the titlebar view.

[jdufault, 2016-07-25 22:17:33]

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/100001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:304:
base::Optional<gfx::VectorIconId> tray_icon =
On 2016/07/25 19:57:53, Evan Stade wrote:
> On 2016/07/25 19:28:29, jdufault wrote:
> > On 2016/07/22 23:04:34, Evan Stade wrote:
> > > I don't think base::Optional is necessary here, typically we return
> > > gfx::VectorIconId::VECTOR_ICON_NONE for a non-value. Since
> PaletteToolManager
> > is
> > > in some other CL and I don't want to go hunting for it, I'll just ask: why
> > > doesn't PaletteToolManager::GetActiveTrayIcon incorporate the fallback
icon
> > > logic?
> > 
> > I've removed the base::Optional bit.
> > 
> > The fallback logic resides here because PaletteToolManager isn't responsible
> for
> > any view computations. It's essentially just a lifetime manager.
> > 
> > View logic is either in this class, or the actual tools. In a previous CL,
all
> > of the tray icons were in this file, but I decided to move the icons to the
> > tools so that all of the tool-specific data stayed in one place.
> 
> sorry, still don't follow. I tracked down where this was being added. Why is
it
> not
> 
> PaletteTool::GetActiveTrayIcon() {
>   return gfx::VectorIconId::PALETTE_TRAY_ICON_DEFAULT;
> }

Done.

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:46: // Width of the palette
itself.
On 2016/07/25 19:57:54, Evan Stade wrote:
> nit: specify unit (dp)

Done.

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:69: class TitleBarView :
public views::View {
On 2016/07/25 19:57:54, Evan Stade wrote:
> doesn't seem like you need a new class for this? Can just create a View and do
> all this stuff.

Done.

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:81: 0,
ash::kTrayPopupPaddingHorizontal, 0, 0));
On 2016/07/25 19:57:54, Evan Stade wrote:
> I would put this on the whole TitleBarView. I'm surprised you only want it on
> one side though, given the name (PaddingHorizontal rather than Indent or
> something).

The name isn't great, but it's a shared constant that I think fits here.

There is no padding on the right because the right-most button already accounts
for it (the button extends all the way to the edge and the UI does not align
with the mocks if there is padding).

I've moved the border to the root view, though I can't decide where the best
place is for it.

https://codereview.chromium.org/2148573002/diff/120001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:167:
bubble_view->set_margins(gfx::Insets(kBubbleViewTopMargin, 0, 0, 0));
On 2016/07/25 19:57:54, Evan Stade wrote:
> does this not square off the bottom corners of the bubble? Perhaps not if the
bg
> is transparent.

Not that I can tell.

> I think it would be slightly cleaner to set the margins to empty and cook
> kBubbleViewTopMargin into the titlebar view.

Done.

[Evan Stade, 2016-07-25 23:32:06]

lgtm

https://codereview.chromium.org/2148573002/diff/140001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/140001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:48: const int kSeparatorInset
= 10;
nit: imo, this kind of constant which is only used in one place should be
defined right above the place it's used (i.e. inside CreateSeparator). You could
add a comment here to describe how it's used but there's no better docs than the
code itself.

https://codereview.chromium.org/2148573002/diff/140001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:50: const int
kBubbleViewTopMargin = 7;
this should probably be shared with something. It's close enough to
BubbleDialogDelegate's "compact" margins (6) that I would say you should use
that instead.

You could do this with:
tray_bubble_view->UseCompactMargins();
tray_bubble_view->set_margins(tray_bubble_view->margins().top(), 0, 0, 0);

[For context, I've been trying for months to make the bajillions of secondary UI
surfaces, like this one, conform to more standard sizing and spacing specs, so
I'm averse to adding new, unshared constants.]

[jdufault, 2016-07-25 23:44:39]

https://codereview.chromium.org/2148573002/diff/140001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2148573002/diff/140001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:48: const int kSeparatorInset
= 10;
On 2016/07/25 23:32:06, Evan Stade wrote:
> nit: imo, this kind of constant which is only used in one place should be
> defined right above the place it's used (i.e. inside CreateSeparator). You
could
> add a comment here to describe how it's used but there's no better docs than
the
> code itself.

Moved to inside of CreateSeparator.

https://codereview.chromium.org/2148573002/diff/140001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:50: const int
kBubbleViewTopMargin = 7;
On 2016/07/25 23:32:06, Evan Stade wrote:
> this should probably be shared with something. It's close enough to
> BubbleDialogDelegate's "compact" margins (6) that I would say you should use
> that instead.
> 
> You could do this with:
> tray_bubble_view->UseCompactMargins();
> tray_bubble_view->set_margins(tray_bubble_view->margins().top(), 0, 0, 0);
> 
> [For context, I've been trying for months to make the bajillions of secondary
UI
> surfaces, like this one, conform to more standard sizing and spacing specs, so
> I'm averse to adding new, unshared constants.]

Done.

[jdufault, 2016-07-25 23:44:46]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-07-25 23:44:47]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2148573002/#ps160001
(title: "Nits")

[commit-bot: I haz the power, 2016-07-25 23:45:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 00:41:33]

Description was changed from

==========
Add palette tray to ash.

Design doc: go/caebn

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
==========

to

==========
Add palette tray to ash.

Design doc: go/caebn

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
==========

[commit-bot: I haz the power, 2016-07-26 00:41:35]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-07-26 00:44:08]

Description was changed from

==========
Add palette tray to ash.

Design doc: go/caebn

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251
==========

to

==========
Add palette tray to ash.

Design doc: go/caebn

This is dependent on a number of CLs:
- https://codereview.chromium.org/2147783002/
- https://codereview.chromium.org/2140343002/
- https://codereview.chromium.org/2143073003/
- https://codereview.chromium.org/2116033002/

BUG=625251

Committed: https://crrev.com/b9918821e0303c84ef56af1d753345b819b0a25c
Cr-Commit-Position: refs/heads/master@{#407654}
==========

[commit-bot: I haz the power, 2016-07-26 00:44:10]

Patchset 8 (id:??) landed as
https://crrev.com/b9918821e0303c84ef56af1d753345b819b0a25c
Cr-Commit-Position: refs/heads/master@{#407654}