Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2148563003: DevTools: Add reload button to disconnection dialog (Closed)

Created:
4 years, 5 months ago by paulirish
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add reload button to disconnection dialog BUG=627640 Committed: https://crrev.com/6969b66d655ffcd3b65b000316c6e8a51ae80302 Cr-Commit-Position: refs/heads/master@{#406669}

Patch Set 1 #

Total comments: 5

Patch Set 2 : nits #

Patch Set 3 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/remoteDebuggingTerminatedScreen.css View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
paulirish
4 years, 5 months ago (2016-07-12 23:03:02 UTC) #3
paulirish
ptal. screenshot in the bug.
4 years, 5 months ago (2016-07-12 23:03:16 UTC) #4
pfeldman
lgtm % nits https://codereview.chromium.org/2148563003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/2148563003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode983 third_party/WebKit/Source/devtools/front_end/main/Main.js:983: function reloadDevTools() { { goes next ...
4 years, 5 months ago (2016-07-13 17:29:24 UTC) #5
paulirish
nits done https://codereview.chromium.org/2148563003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/2148563003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode993 third_party/WebKit/Source/devtools/front_end/main/Main.js:993: var button = createTextButton(WebInspector.UIString("Reconnect DevTools"), reloadDevTools); On ...
4 years, 5 months ago (2016-07-13 19:01:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148563003/40001
4 years, 5 months ago (2016-07-13 19:02:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/243744)
4 years, 5 months ago (2016-07-13 21:08:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148563003/40001
4 years, 5 months ago (2016-07-20 17:29:34 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 21:03:24 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6969b66d655ffcd3b65b000316c6e8a51ae80302 Cr-Commit-Position: refs/heads/master@{#406669}
4 years, 5 months ago (2016-07-20 21:08:57 UTC) #16
paulirish
4 years, 4 months ago (2016-07-28 18:56:39 UTC) #17
Message was sent while issue was closed. 
pavel, How can we merge this to the frontend that node-nightly is using?

Powered by Google App Engine
This is Rietveld 408576698