Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: runtime/bin/fuchsia_test.cc

Issue 2148533002: Fuchsia: Platform specific calls needed to Initialize and Cleanup VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/vmservice.cc » ('j') | runtime/vm/os_fuchsia.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/fuchsia_test.cc
diff --git a/runtime/bin/fuchsia_test.cc b/runtime/bin/fuchsia_test.cc
index 802ff31fabaa8c5628ab8a483900e7a57b271489..bbf0ad1a66c35b6cecd013faf1d6bcee966d627f 100644
--- a/runtime/bin/fuchsia_test.cc
+++ b/runtime/bin/fuchsia_test.cc
@@ -33,6 +33,17 @@ int main(void) {
free(error);
return -1;
}
+
+ fprintf(stderr, "Calling Dart_Cleanup\n");
+ fflush(stderr);
siva 2016/07/13 00:27:16 Would it make sense to replace these fprintf, fflu
zra 2016/07/13 16:04:33 Done. Hadn't started porting libdart_builtin yet,
+ error = Dart_Cleanup();
+ if (error != NULL) {
+ fprintf(stderr, "VM Cleanup failed: %s\n", error);
+ fflush(stderr);
+ free(error);
+ return -1;
+ }
+
fprintf(stderr, "Success!\n");
fflush(stderr);
return 0;
« no previous file with comments | « no previous file | runtime/lib/vmservice.cc » ('j') | runtime/vm/os_fuchsia.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698