Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2148533002: Fuchsia: Platform specific calls needed to Initialize and Cleanup VM. (Closed)

Created:
4 years, 5 months ago by zra
Modified:
4 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Platform specific calls needed to Initialize and Cleanup VM. fuchsia_test now succeeds. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/64e9017629a597c21dd1c74d57044a9e7efa4fa5

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -67 lines) Patch
M runtime/bin/bin.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/fuchsia_test.cc View 1 2 chunks +27 lines, -11 lines 0 comments Download
A + runtime/bin/log_fuchsia.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/vmservice.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/atomic_fuchsia.h View 2 chunks +7 lines, -13 lines 0 comments Download
M runtime/vm/cpuinfo_fuchsia.cc View 1 2 chunks +34 lines, -10 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 4 chunks +75 lines, -19 lines 0 comments Download
M runtime/vm/virtual_memory.h View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/virtual_memory_fuchsia.cc View 3 chunks +42 lines, -7 lines 0 comments Download
M tools/fuchsia_link.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 5 months ago (2016-07-12 21:32:29 UTC) #2
siva
lgtm https://codereview.chromium.org/2148533002/diff/1/runtime/bin/fuchsia_test.cc File runtime/bin/fuchsia_test.cc (right): https://codereview.chromium.org/2148533002/diff/1/runtime/bin/fuchsia_test.cc#newcode38 runtime/bin/fuchsia_test.cc:38: fflush(stderr); Would it make sense to replace these ...
4 years, 5 months ago (2016-07-13 00:27:16 UTC) #3
zra
https://codereview.chromium.org/2148533002/diff/1/runtime/bin/fuchsia_test.cc File runtime/bin/fuchsia_test.cc (right): https://codereview.chromium.org/2148533002/diff/1/runtime/bin/fuchsia_test.cc#newcode38 runtime/bin/fuchsia_test.cc:38: fflush(stderr); On 2016/07/13 00:27:16, siva wrote: > Would it ...
4 years, 5 months ago (2016-07-13 16:04:33 UTC) #4
zra
4 years, 5 months ago (2016-07-13 16:12:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
64e9017629a597c21dd1c74d57044a9e7efa4fa5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698