Calculate border-box dimensions correctly for cells

Calculate border-box dimensions correctly for cells

When constraining a height on a cell according to box sizing we need to exclude the intrinsic
padding on table cells (calculated to line up the content of the cells with the
baseline of its neighbours) but include any collapsed borders the cells have
picked up from the row/table.

BUG=627305
Committed: https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e
Cr-Commit-Position: refs/heads/master@{#406775}

[rhogan, 2016-07-18 21:38:10]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 21:39:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2016-07-18 21:44:48]

Description was changed from

==========
Calculate border-box dimensions correctly for cells

BUG=627305
==========

to

==========
Calculate border-box dimensions correctly for cells

When constraining a height on a cell according to box sizing we need to exclude
the intrinsic
padding on table cells (calculated to line up the content of the cells with the
baseline of its neighbours) but include any collapsed borders the cells have
picked up from the row/table.

BUG=627305
==========

[rhogan, 2016-07-18 21:44:48]

robhogan@gmail.com changed reviewers:
+ dgrogan@chromium.org, eae@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:36:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eae, 2016-07-20 18:25:52]

This is great, thank you!

LGTM

[eae, 2016-07-20 18:26:00]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-07-20 18:26:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 21:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:47:33]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgrogan, 2016-07-20 21:48:27]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 03:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 03:34:58]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgrogan, 2016-07-21 04:39:05]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-07-21 04:39:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 05:59:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-21 06:00:46]

Description was changed from

==========
Calculate border-box dimensions correctly for cells

When constraining a height on a cell according to box sizing we need to exclude
the intrinsic
padding on table cells (calculated to line up the content of the cells with the
baseline of its neighbours) but include any collapsed borders the cells have
picked up from the row/table.

BUG=627305
==========

to

==========
Calculate border-box dimensions correctly for cells

When constraining a height on a cell according to box sizing we need to exclude
the intrinsic
padding on table cells (calculated to line up the content of the cells with the
baseline of its neighbours) but include any collapsed borders the cells have
picked up from the row/table.

BUG=627305

Committed: https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e
Cr-Commit-Position: refs/heads/master@{#406775}
==========

[commit-bot: I haz the power, 2016-07-21 06:00:47]

Patchset 4 (id:??) landed as
https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e
Cr-Commit-Position: refs/heads/master@{#406775}