Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2148503002: Fix capture of debug information when corruption is detected. (Closed)

Created:
4 years, 5 months ago by bcwhite
Modified:
4 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix capture of debug information when corruption is detected. BUG=600717 Committed: https://crrev.com/38c5e05f22bc205fc270478546956e73b8e13407 Cr-Commit-Position: refs/heads/master@{#404992}

Patch Set 1 #

Patch Set 2 : fix signed/unsigned comparison #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M base/metrics/histogram_snapshot_manager.cc View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
bcwhite
4 years, 5 months ago (2016-07-12 20:25:44 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 5 months ago (2016-07-12 20:42:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148503002/20001
4 years, 5 months ago (2016-07-12 21:10:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/200184)
4 years, 5 months ago (2016-07-12 22:51:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148503002/20001
4 years, 5 months ago (2016-07-13 02:15:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 03:58:22 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:58:39 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:01:01 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/38c5e05f22bc205fc270478546956e73b8e13407
Cr-Commit-Position: refs/heads/master@{#404992}

Powered by Google App Engine
This is Rietveld 408576698