[Mac] Fix download shelf items

[Mac] Fix download shelf items

Make sure that the download shelf items are updated after we exit
fullscreen.

BUG=600411
Committed: https://crrev.com/b918411255a8a4bdba4f17e417ac6a8fcd00c38c
Cr-Commit-Position: refs/heads/master@{#408839}

[spqchan, 2016-07-12 20:18:28]

Description was changed from

==========
[Mac] Fix download shelf items after exiting fullscreen

BUG=
==========

to

==========
[Mac] Fix download shelf items

Make sure that the download shelf items are updated after we exit
fullscreen.

BUG=600411
==========

[spqchan, 2016-07-12 20:28:14]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-07-12 20:28:15]

PTAL

[Robert Sesek, 2016-07-12 23:33:13]

https://codereview.chromium.org/2148483002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_shelf_controller.mm (right):

https://codereview.chromium.org/2148483002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_shelf_controller.mm:490: [controller
updateViews];
Can you call [[controller view] setNeedsDisplay:YES] instead?

[spqchan, 2016-07-20 01:13:43]

On 2016/07/12 23:33:13, Robert Sesek wrote:
>
https://codereview.chromium.org/2148483002/diff/20001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/download/download_shelf_controller.mm (right):
> 
>
https://codereview.chromium.org/2148483002/diff/20001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/download/download_shelf_controller.mm:490: [controller
> updateViews];
> Can you call [[controller view] setNeedsDisplay:YES] instead?

Sorry for the delay. 

Good point. Unfortunately it doesn't work since calling the parent view won't
recursively call setNeedsDisplay for the subviews.
I noticed that we don't need to call setNeedsDisplay for cell_ though and made a
change for it

[spqchan, 2016-07-29 17:37:34]

ping

[Robert Sesek, 2016-07-29 20:13:29]

lgtm

[spqchan, 2016-07-30 00:16:34]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-07-30 00:16:43]

On 2016/07/29 20:13:29, Robert Sesek wrote:
> lgtm

thanks!

[commit-bot: I haz the power, 2016-07-30 00:16:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:00:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 01:00:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[spqchan, 2016-07-30 01:04:10]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-07-30 01:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:57:03]

Description was changed from

==========
[Mac] Fix download shelf items

Make sure that the download shelf items are updated after we exit
fullscreen.

BUG=600411
==========

to

==========
[Mac] Fix download shelf items

Make sure that the download shelf items are updated after we exit
fullscreen.

BUG=600411
==========

[commit-bot: I haz the power, 2016-07-30 01:57:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-30 01:58:15]

Description was changed from

==========
[Mac] Fix download shelf items

Make sure that the download shelf items are updated after we exit
fullscreen.

BUG=600411
==========

to

==========
[Mac] Fix download shelf items

Make sure that the download shelf items are updated after we exit
fullscreen.

BUG=600411

Committed: https://crrev.com/b918411255a8a4bdba4f17e417ac6a8fcd00c38c
Cr-Commit-Position: refs/heads/master@{#408839}
==========

[commit-bot: I haz the power, 2016-07-30 01:58:16]

Patchset 4 (id:??) landed as
https://crrev.com/b918411255a8a4bdba4f17e417ac6a8fcd00c38c
Cr-Commit-Position: refs/heads/master@{#408839}

[Robert Sesek, 2016-08-03 21:40:26]

What about using cr_recursivelySetNeedsDisplay from
https://cs.chromium.org/chromium/src/ui/base/cocoa/nsview_additions.h?sq=pack...
?

[spqchan, 2016-08-04 02:03:21]

On 2016/08/03 21:40:26, Robert Sesek wrote:
> What about using cr_recursivelySetNeedsDisplay from
>
https://cs.chromium.org/chromium/src/ui/base/cocoa/nsview_additions.h?sq=pack...
> ?

Oh, that's a good point, I have no idea we have that. I'll give that a go